Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: chrome/browser/metrics/metrics_services_manager.cc

Issue 293393010: Move initial metrics gathering tasks out of MetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/metrics_services_manager.h" 5 #include "chrome/browser/metrics/metrics_services_manager.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "chrome/browser/metrics/chrome_metrics_service_client.h" 9 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
10 #include "chrome/browser/metrics/metrics_service.h" 10 #include "chrome/browser/metrics/metrics_service.h"
(...skipping 10 matching lines...) Expand all
21 MetricsServicesManager::MetricsServicesManager(PrefService* local_state) 21 MetricsServicesManager::MetricsServicesManager(PrefService* local_state)
22 : local_state_(local_state) { 22 : local_state_(local_state) {
23 DCHECK(local_state); 23 DCHECK(local_state);
24 } 24 }
25 25
26 MetricsServicesManager::~MetricsServicesManager() { 26 MetricsServicesManager::~MetricsServicesManager() {
27 } 27 }
28 28
29 MetricsService* MetricsServicesManager::GetMetricsService() { 29 MetricsService* MetricsServicesManager::GetMetricsService() {
30 DCHECK(thread_checker_.CalledOnValidThread()); 30 DCHECK(thread_checker_.CalledOnValidThread());
31 return GetMetricsServiceClient()->metrics_service();
32 }
33
34 ChromeMetricsServiceClient* MetricsServicesManager::GetMetricsServiceClient() {
35 DCHECK(thread_checker_.CalledOnValidThread());
31 if (!metrics_service_client_) { 36 if (!metrics_service_client_) {
32 metrics_service_client_ = 37 metrics_service_client_ =
33 ChromeMetricsServiceClient::Create(GetMetricsStateManager()).Pass(); 38 ChromeMetricsServiceClient::Create(GetMetricsStateManager()).Pass();
34 } 39 }
35 return metrics_service_client_->metrics_service(); 40 return metrics_service_client_.get();
41 }
42
43 PluginMetricsProvider* MetricsServicesManager::GetPluginMetricsProvider() {
44 return GetMetricsServiceClient()->plugin_metrics_provider();
36 } 45 }
37 46
38 rappor::RapporService* MetricsServicesManager::GetRapporService() { 47 rappor::RapporService* MetricsServicesManager::GetRapporService() {
39 DCHECK(thread_checker_.CalledOnValidThread()); 48 DCHECK(thread_checker_.CalledOnValidThread());
40 if (!rappor_service_) 49 if (!rappor_service_)
41 rappor_service_.reset(new rappor::RapporService); 50 rappor_service_.reset(new rappor::RapporService);
42 return rappor_service_.get(); 51 return rappor_service_.get();
43 } 52 }
44 53
45 chrome_variations::VariationsService* 54 chrome_variations::VariationsService*
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 #if defined(GOOGLE_CHROME_BUILD) 86 #if defined(GOOGLE_CHROME_BUILD)
78 #if defined(OS_CHROMEOS) 87 #if defined(OS_CHROMEOS)
79 chromeos::CrosSettings::Get()->GetBoolean(chromeos::kStatsReportingPref, 88 chromeos::CrosSettings::Get()->GetBoolean(chromeos::kStatsReportingPref,
80 &enabled); 89 &enabled);
81 #else 90 #else
82 enabled = local_state_->GetBoolean(prefs::kMetricsReportingEnabled); 91 enabled = local_state_->GetBoolean(prefs::kMetricsReportingEnabled);
83 #endif // #if defined(OS_CHROMEOS) 92 #endif // #if defined(OS_CHROMEOS)
84 #endif // defined(GOOGLE_CHROME_BUILD) 93 #endif // defined(GOOGLE_CHROME_BUILD)
85 return enabled; 94 return enabled;
86 } 95 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698