Issue 293393009: For reference only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293393009: For reference only.

Created:
6 years, 7 months ago by darin (slow to review)

Modified:
6 years, 7 months ago

Reviewers:
qsr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Patch Set 2 : with more idiomatic C++ bindings #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1494 lines, -0 lines)			Patch
A	mojo/public/cpp/bindings/gen/sample_service.mojom.h	View	1	1 chunk	+431 lines, -0 lines	2 comments	Download
A	mojo/public/cpp/bindings/gen/sample_service.mojom.cc	View	1	1 chunk	+880 lines, -0 lines	0 comments	Download
A	mojo/public/cpp/bindings/gen/sample_service.mojom-internal.h	View	1	1 chunk	+183 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

qsr

https://codereview.chromium.org/293393009/diff/20001/mojo/public/cpp/bindings/gen/sample_service.mojom.h File mojo/public/cpp/bindings/gen/sample_service.mojom.h (right): https://codereview.chromium.org/293393009/diff/20001/mojo/public/cpp/bindings/gen/sample_service.mojom.h#newcode137 mojo/public/cpp/bindings/gen/sample_service.mojom.h:137: int32_t v3; I might be missing something obvious, but ...

6 years, 7 months ago (2014-05-27 07:00:46 UTC) #1

darin (slow to review)

6 years, 7 months ago (2014-05-27 18:01:23 UTC) #2

https://codereview.chromium.org/293393009/diff/20001/mojo/public/cpp/bindings...
File mojo/public/cpp/bindings/gen/sample_service.mojom.h (right):

https://codereview.chromium.org/293393009/diff/20001/mojo/public/cpp/bindings...
mojo/public/cpp/bindings/gen/sample_service.mojom.h:137: int32_t v3;
On 2014/05/27 07:00:46, qsr wrote:
> I might be missing something obvious, but shouldn't this be reordered into:
> int32_t v1;
> int32_t v3;
> int64_t v2;
> ?

These structs do not need to be packed. They are just copies. As such, I thought
I would list out the fields in the same order as they appear in the mojom file.
I figure developers are likely to write their mojom files using logical grouping
of fields, and seeing that logical grouping reflecting in these classes felt
like a good thing.

Expand Messages | Collapse Messages

Issue 293393009: For reference only.

Description

Patch Set 1 #

Patch Set 2 : with more idiomatic C++ bindings #

Messages