Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 293393003: D8 should send idle notification even after the last run. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
marja
CC:
v8-dev
Visibility:
Public.

Description

D8 should send idle notification even after the last run. This, in combination with changes to the bot, should weed out false negatives. R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/d8.cc View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 7 months ago (2014-05-26 12:06:05 UTC) #1
Yang
On 2014/05/26 12:06:05, Yang wrote: the comment should go on to say: ... for memory ...
6 years, 7 months ago (2014-05-26 12:06:35 UTC) #2
marja
lgtm
6 years, 7 months ago (2014-05-26 13:16:02 UTC) #3
Yang
6 years, 7 months ago (2014-05-26 13:32:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21496 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698