Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/infobars/confirm_infobar_controller.mm

Issue 2933833002: [iOS] Break retain cycle in InfoBars. (Closed)
Patch Set: Addressed comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/passwords/update_password_infobar_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/infobars/confirm_infobar_controller.mm
diff --git a/ios/chrome/browser/infobars/confirm_infobar_controller.mm b/ios/chrome/browser/infobars/confirm_infobar_controller.mm
index 8f3ac3cb8d19c2e07b37560ed2fae18b66381204..d4b2a94b13d76e42e7653bf2fefc8c5801741d68 100644
--- a/ios/chrome/browser/infobars/confirm_infobar_controller.mm
+++ b/ios/chrome/browser/infobars/confirm_infobar_controller.mm
@@ -118,9 +118,10 @@ - (void)updateInfobarLabel:(InfoBarView*)view {
base::ReplaceFirstSubstringAfterOffset(
&messageText, 0, _confirmInfobarDelegate->GetLinkText(), msgLink);
+ __weak ConfirmInfoBarController* weakSelf = self;
[view addLabel:base::SysUTF16ToNSString(messageText)
action:^(NSUInteger tag) {
- [self infobarLinkDidPress:tag];
+ [weakSelf infobarLinkDidPress:tag];
}];
} else {
NSString* label =
« no previous file with comments | « no previous file | ios/chrome/browser/passwords/update_password_infobar_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698