Issue 293383007: Mojo: Move common/basic functions declarations from mojo/public/c/system/core.h to .../functions.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293383007: Mojo: Move common/basic functions declarations from mojo/public/c/system/core.h to .../functions.h. (Closed)

Created:
6 years, 7 months ago by viettrungluu

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Move common/basic functions declarations from mojo/public/c/system/core.h to .../functions.h. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273042

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : rebased #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -67 lines)			Patch
M	mojo/mojo_public.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/c/system/core.h	View		2 chunks	+5 lines, -63 lines	0 comments	Download
A	mojo/public/c/system/functions.h	View	1	1 chunk	+87 lines, -0 lines	0 comments	Download
M	mojo/public/c/system/types.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

(Dependent on https://codereview.chromium.org/307533002/.)

6 years, 7 months ago (2014-05-27 18:22:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/293383007/40001

6 years, 7 months ago (2014-05-27 19:43:56 UTC) #4

viettrungluu

6 years, 7 months ago (2014-05-27 21:36:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r273042 (presubmit successful).

Expand Messages | Collapse Messages