Follow-up to CLs 2933723002 and 2932973003.

Follow-up to CLs 2933723002 and 2932973003.

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/ea30fb6a0d11fa79d5e312a62fae2c3f31e7aee4

[ahe, 2017-06-12 09:10:09]

Patchset #2 (id:20001) has been deleted

[ahe, 2017-06-12 11:56:40]

Patchset #1 (id:1) has been deleted

[ahe, 2017-06-12 11:57:35]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, paulberry@google.com

[Paul Berry, 2017-06-12 16:23:12]

lgtm

https://codereview.chromium.org/2933813002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/source_library_builder.dart (right):

https://codereview.chromium.org/2933813002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:297:
addCompileTimeError(other.charOffset, "'$name' is used here.");
Not a blocking issue for this CL, but I believe this is going to be problematic
for integration with analyzer, since analyzer sorts errors by character
position, so the user is not going to understand the meaning of the "'$name' is
used here." error.

The situation is even worse for IDE integration, where the errors are frequently
displayed as popups associated with the source code location.

[ahe, 2017-06-12 16:34:08]

Thank you, Paul. Good point, you made me aware of something I hadn't thought
about before.

https://codereview.chromium.org/2933813002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/source_library_builder.dart (right):

https://codereview.chromium.org/2933813002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:297:
addCompileTimeError(other.charOffset, "'$name' is used here.");
On 2017/06/12 16:23:12, Paul Berry wrote:
> Not a blocking issue for this CL, but I believe this is going to be
problematic
> for integration with analyzer, since analyzer sorts errors by character
> position, so the user is not going to understand the meaning of the "'$name'
is
> used here." error.
> 
> The situation is even worse for IDE integration, where the errors are
frequently
> displayed as popups associated with the source code location.

I'm aware of this problem, and I'm not sure what the best solution is. Either,
each message should be worded so it can be a standalone message, or we should
add more structure to the diagnostic objects.

I hadn't really thought about how bad this is for IDE integration, so I'm glad
you mentioned it.

[ahe, 2017-06-13 07:45:47]

Description was changed from

==========
Follow-up to CLs 2933723002 and 2932973003.
==========

to

==========
Follow-up to CLs 2933723002 and 2932973003.

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ea30fb6a0d11fa79d5e312a62fae2c3f31e7aee4
==========

[ahe, 2017-06-13 07:45:48]

Committed patchset #1 (id:40001) manually as
ea30fb6a0d11fa79d5e312a62fae2c3f31e7aee4.