Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/android/webapk/webapk_install_service.h

Issue 2933783002: [Android WebAPK] Change WebAPK update into two phases (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_install_service.h
diff --git a/chrome/browser/android/webapk/webapk_install_service.h b/chrome/browser/android/webapk/webapk_install_service.h
index 59146982699c606f63f51a48fef6dcc7b0f645fa..fa32962e90696adca68830df9850e64425b8eff9 100644
--- a/chrome/browser/android/webapk/webapk_install_service.h
+++ b/chrome/browser/android/webapk/webapk_install_service.h
@@ -8,10 +8,12 @@
#include <map>
#include <set>
#include <string>
+#include <vector>
dominickn 2017/06/14 00:14:23 #include <memory> for std::unique_ptr
#include "base/callback.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
+#include "base/strings/string16.h"
#include "components/keyed_service/core/keyed_service.h"
#include "url/gurl.h"
@@ -64,15 +66,12 @@ class WebApkInstallService : public KeyedService {
// Talks to the Chrome WebAPK server to update a WebAPK on the server and to
// the Google Play server to install the downloaded WebAPK. Calls |callback|
- // after the request to install the WebAPK is sent to Google Play.
- void UpdateAsync(
- const ShortcutInfo& shortcut_info,
- const SkBitmap& shortcut_icon,
- const std::string& webapk_package,
- int webapk_version,
- const std::map<std::string, std::string>& icon_url_to_murmur2_hash,
- bool is_manifest_stale,
- const FinishCallback& finish_callback);
+ // once the update completed or failed.
+ void UpdateAsync(const std::string& webapk_package,
+ const GURL& start_url,
+ const base::string16& short_name,
+ std::unique_ptr<std::vector<uint8_t>> serialized_proto,
+ const FinishCallback& finish_callback);
private:
// Called once the install/update completed or failed.

Powered by Google App Engine
This is Rietveld 408576698