Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2933763002: Update golden files. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add bug number for native_is_illegal. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -33 lines) Patch
M pkg/front_end/test/fasta/compile.status View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/outline.status View 1 2 chunks +1 line, -3 lines 0 comments Download
M pkg/front_end/testcases/covariant_generic.dart.direct.expect View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/external.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/invocations.dart.direct.expect View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/rasta/class_hierarchy.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/duplicated_mixin.dart.direct.expect View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/rasta/generic_factory.dart.direct.expect View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/rasta/generic_factory.dart.outline.expect View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/rasta/mixin_library.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/super_operator.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/switch_fall_through.dart.direct.expect View 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/rasta/type_literals.dart.direct.expect View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/rasta/typedef.dart.direct.expect View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/redirecting_factory.dart.direct.expect View 2 chunks +12 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (6 generated)
ahe
https://codereview.chromium.org/2933763002/diff/20001/pkg/front_end/testcases/rasta/switch_fall_through.dart.direct.expect File pkg/front_end/testcases/rasta/switch_fall_through.dart.direct.expect (right): https://codereview.chromium.org/2933763002/diff/20001/pkg/front_end/testcases/rasta/switch_fall_through.dart.direct.expect#newcode16 pkg/front_end/testcases/rasta/switch_fall_through.dart.direct.expect:16: throw new core::FallThroughError::•(); Actually required by specification. Same for ...
3 years, 6 months ago (2017-06-11 20:46:31 UTC) #3
Paul Berry
lgtm
3 years, 6 months ago (2017-06-12 16:28:45 UTC) #6
ahe
3 years, 6 months ago (2017-06-13 07:25:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:80001) manually as
b06a3602b4748baf4a50e1005344eb20650f4fae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698