Throw NSM on unresolved factory redirection.

pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.kernel_class_builder;
 
 import 'package:kernel/ast.dart'
     show
         Class,
         Constructor,
         DartType,
         Expression,
-        ExpressionStatement,
         Field,
         FunctionNode,
         InterfaceType,
         ListLiteral,
         Member,
         Name,
         Procedure,
         ProcedureKind,
         StaticGet,
-        StringLiteral,
         Supertype,
-        Throw,
         VariableDeclaration;
 
 import 'package:kernel/class_hierarchy.dart' show ClassHierarchy;
 
 import '../errors.dart' show internalError;
 
-import '../messages.dart' show warning;
-
 import '../dill/dill_member_builder.dart' show DillMemberBuilder;
 
 import 'kernel_builder.dart'
     show
         Builder,
         ClassBuilder,
         ConstructorReferenceBuilder,
         KernelLibraryBuilder,
         KernelProcedureBuilder,
         KernelTypeBuilder,
@@ skipping 82 matching lines @@
           if (redirectionTarget != null) {
             assert(builder.actualBody == null);
             Builder targetBuilder = redirectionTarget.target;
             addRedirectingConstructor(builder, library);
             if (targetBuilder is ProcedureBuilder) {
               Member target = targetBuilder.target;
               builder.body = new RedirectingFactoryBody(target);
             } else if (targetBuilder is DillMemberBuilder) {
               builder.body = new RedirectingFactoryBody(targetBuilder.member);
             } else {
-              // TODO(ahe): Throw NSM error. This requires access to core
-              // types.
               String message = "Redirection constructor target not found: "
                   "${redirectionTarget.fullNameForErrors}";
-              warning(library.fileUri, -1, message);
-              builder.body = new ExpressionStatement(
-                  new Throw(new StringLiteral(message)));
+              if (builder.isConst) {
+                addCompileTimeError(builder.charOffset, message);
+              } else {
+                addWarning(builder.charOffset, message);
+              }
+              // CoreTypes aren't computed yet, and this is the outline
+              // phase. So we can't and shouldn't create a method body.
+              builder.body = new RedirectingFactoryBody.unresolved(
+                  redirectionTarget.fullNameForErrors);
             }
           }
         }
       }
     }
     return count;
   }
 
   void addRedirectingConstructor(
       KernelProcedureBuilder constructor, KernelLibraryBuilder library) {
     // Add a new synthetic field to this class for representing factory
     // constructors. This is used to support resolving such constructors in
     // source code.
     //
     // The synthetic field looks like this:
     //
     //     final _redirecting# = [c1, ..., cn];
     //
     // Where each c1 ... cn are an instance of [StaticGet] whose target is
     // [constructor.target].
     //
-    // TODO(ahe): Generate the correct factory body instead.
+    // TODO(ahe): Add a kernel node to represent redirecting factory bodies.
     DillMemberBuilder constructorsField =
         scope.local.putIfAbsent("_redirecting#", () {
       ListLiteral literal = new ListLiteral(<Expression>[]);
       Name name = new Name("_redirecting#", library.library);
       Field field = new Field(name,
           isStatic: true, initializer: literal, fileUri: cls.fileUri)
         ..fileOffset = cls.fileOffset;
       cls.addMember(field);
       return new DillMemberBuilder(field, this);
     });
@@ skipping 97 matching lines @@
       }
     }
   }
 
   String get fullNameForErrors {
     return isMixinApplication
         ? "${supertype.fullNameForErrors} with ${mixedInType.fullNameForErrors}"
         : name;
   }
 }