Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 2933713002: Add a couple of lints to the options files (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M pkg/analysis_server/analysis_options.yaml View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/instrumentation/page/stats_page.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/analysis_options.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/analysis_options.yaml View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/analysis_options.yaml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-10 20:40:39 UTC) #2
devoncarew
lgtm
3 years, 6 months ago (2017-06-11 05:51:35 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-11 16:12:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b928683560ced9532eaf2101f32e1aec0159d4a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698