Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2933663002: Annotate targets of implicit this property gets/sets in inference tests. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Annotate targets of implicit this property gets/sets in inference tests. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6b65fc22f7d9d0f66aa2b368fd4d9fabd7ec4867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -53 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 4 chunks +8 lines, -26 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_inference_f_bounded.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_inference_f_bounded.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_reverse_type_parameters.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_reverse_type_parameters.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_type_on_var_from_field.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_type_on_var_from_field.dart.strong.expect View 1 chunk +23 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_4.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_4.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/refine_binary_expression_type_type_parameter_t_double.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/refine_binary_expression_type_type_parameter_t_int.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/refine_binary_expression_type_type_parameter_t_t.dart View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-09 23:10:07 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-10 00:08:02 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-10 00:41:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6b65fc22f7d9d0f66aa2b368fd4d9fabd7ec4867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698