Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2933643002: Implement type inference for assignments to a static variable. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement type inference for assignments to a static variable. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8f5bcddc316842ebf45271a6136a67405aafacb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+446 lines, -10 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 1 chunk +18 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_static.dart View 1 chunk +59 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_static.dart.direct.expect View 1 chunk +64 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_static.dart.outline.expect View 1 chunk +34 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_static.dart.strong.expect View 1 chunk +64 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_static_upwards.dart View 1 chunk +53 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_static_upwards.dart.direct.expect View 1 chunk +48 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_static_upwards.dart.outline.expect View 1 chunk +21 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_static_upwards.dart.strong.expect View 1 chunk +48 lines, -0 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_kernel.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-09 22:44:56 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-10 00:16:00 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-10 00:36:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f5bcddc316842ebf45271a6136a67405aafacb2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698