Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 293363016: [abort] [webkit test runner] Complete location change when a frame is detached. (Closed)

Created:
6 years, 6 months ago by mkosiba (inactive)
Modified:
6 years, 6 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[webkit test runner] Complete location change when a frame is detached. When working on http://crrev.com/181493007 I found that the fast/loader/unload-hyperlink-targeted.html LayoutTest would hang with that change. It seems to be a mix of two issues: 1) during the execution of this tests the child frame becomes the topLoadingFrame (this is the case with and without the linked patch), and so the test runner waits for it to finish, 2) the child frame is gets detached after the load has committed but before it had finished. This still results in the top frame reporting the load had finished but the child frame only ends up calling didAbortLoad and frameDetached. The combination of these issues leads to the test runner waiting for the detached frame to finishLoading (which it never does leading to a hang). The fix is to complete the ongoing navigation when the frame is detached. BUG=325351 TESTS=run_webkit_tests.py

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698