Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/ia32/macro-assembler-ia32.h

Issue 293363005: LoadUint32() doesn't need a scratch register. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Compile fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_IA32_MACRO_ASSEMBLER_IA32_H_ 5 #ifndef V8_IA32_MACRO_ASSEMBLER_IA32_H_
6 #define V8_IA32_MACRO_ASSEMBLER_IA32_H_ 6 #define V8_IA32_MACRO_ASSEMBLER_IA32_H_
7 7
8 #include "assembler.h" 8 #include "assembler.h"
9 #include "frames.h" 9 #include "frames.h"
10 #include "v8globals.h" 10 #include "v8globals.h"
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 } 458 }
459 459
460 // Modifies the register even if it does not contain a Smi! 460 // Modifies the register even if it does not contain a Smi!
461 void SmiUntag(Register reg, Label* is_smi) { 461 void SmiUntag(Register reg, Label* is_smi) {
462 STATIC_ASSERT(kSmiTagSize == 1); 462 STATIC_ASSERT(kSmiTagSize == 1);
463 sar(reg, kSmiTagSize); 463 sar(reg, kSmiTagSize);
464 STATIC_ASSERT(kSmiTag == 0); 464 STATIC_ASSERT(kSmiTag == 0);
465 j(not_carry, is_smi); 465 j(not_carry, is_smi);
466 } 466 }
467 467
468 void LoadUint32(XMMRegister dst, Register src, XMMRegister scratch); 468 void LoadUint32(XMMRegister dst, Register src);
469 469
470 // Jump the register contains a smi. 470 // Jump the register contains a smi.
471 inline void JumpIfSmi(Register value, 471 inline void JumpIfSmi(Register value,
472 Label* smi_label, 472 Label* smi_label,
473 Label::Distance distance = Label::kFar) { 473 Label::Distance distance = Label::kFar) {
474 test(value, Immediate(kSmiTagMask)); 474 test(value, Immediate(kSmiTagMask));
475 j(zero, smi_label, distance); 475 j(zero, smi_label, distance);
476 } 476 }
477 // Jump if the operand is a smi. 477 // Jump if the operand is a smi.
478 inline void JumpIfSmi(Operand value, 478 inline void JumpIfSmi(Operand value,
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
1083 } \ 1083 } \
1084 masm-> 1084 masm->
1085 #else 1085 #else
1086 #define ACCESS_MASM(masm) masm-> 1086 #define ACCESS_MASM(masm) masm->
1087 #endif 1087 #endif
1088 1088
1089 1089
1090 } } // namespace v8::internal 1090 } } // namespace v8::internal
1091 1091
1092 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_ 1092 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698