1. Dynamic compute the main closure that needs to be run by the main isolate

1. Dynamically compute the main closure that needs to be run by the main isolate
2. Get rid of _getMainClosure()
3. Adjust the AOT compiler to ensure it retains the function associated with
   the main closure without having to include '_getMainClosure()' in the list
   of embedder specified entry points
4. Get rid of the hack in kernel reader to do a delayed patch of
   '_getMainClosure()' in the builtin library.

BUG=
R=aam@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/8b7af73daafedacf0f239d17096703420937af69

[siva, 2017-06-09 20:48:39]

Description was changed from

==========
1. Dynamic compute the main closure that needs to be run by the main isolate
2. Get rid of _getMainClosure()
3. Adjust the AOT compiler to ensure it retains the function associated with
   the main closure without having to include '_getMainClosure()' in the list
   of embedder specified entry points
4. Get rid of the hack in kernel reader to do a delayed patch of
   '_getMainClosure()' in the builtin library.

BUG=
==========

to

==========
1. Dynamically compute the main closure that needs to be run by the main isolate
2. Get rid of _getMainClosure()
3. Adjust the AOT compiler to ensure it retains the function associated with
   the main closure without having to include '_getMainClosure()' in the list
   of embedder specified entry points
4. Get rid of the hack in kernel reader to do a delayed patch of
   '_getMainClosure()' in the builtin library.

BUG=
==========

[siva, 2017-06-09 21:00:34]

asiva@google.com changed reviewers:
+ aam@google.com, rmacnak@google.com

[aam, 2017-06-12 15:38:34]

On 2017/06/09 21:31:00, siva wrote:

+kmillikin, who looked at this couple weeks ago.

lgtm! 

When this is pulled into flutter,
https://github.com/flutter/engine/blob/master/runtime/dart_controller.cc#L88 had
to be tweaked too, right?

[rmacnak, 2017-06-15 01:48:54]

lgtm

https://codereview.chromium.org/2933603002/diff/20001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/2933603002/diff/20001/runtime/include/dart_ap...
runtime/include/dart_api.h:1625: DART_EXPORT Dart_Handle
Dart_GetClosure(Dart_Handle library,
We should update Dart_GetField to do closurization to be consistent with the
language o.foo and mirrors getField. Same with Dart_Invoke and call through
getters.

https://codereview.chromium.org/2933603002/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2933603002/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:695: const Object& main_closure =
Object::Handle(lib.GetFunctionClosure(name));
Propagate if error

[siva, 2017-06-15 17:34:41]

https://codereview.chromium.org/2933603002/diff/20001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/2933603002/diff/20001/runtime/include/dart_ap...
runtime/include/dart_api.h:1625: DART_EXPORT Dart_Handle
Dart_GetClosure(Dart_Handle library,
On 2017/06/15 01:48:54, rmacnak wrote:
> We should update Dart_GetField to do closurization to be consistent with the
> language o.foo and mirrors getField. Same with Dart_Invoke and call through
> getters.

I have added issue https://github.com/dart-lang/sdk/issues/29893 to track this.

https://codereview.chromium.org/2933603002/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2933603002/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:695: const Object& main_closure =
Object::Handle(lib.GetFunctionClosure(name));
On 2017/06/15 01:48:54, rmacnak wrote:
> Propagate if error

Done.

[siva, 2017-06-15 17:40:48]

Description was changed from

==========
1. Dynamically compute the main closure that needs to be run by the main isolate
2. Get rid of _getMainClosure()
3. Adjust the AOT compiler to ensure it retains the function associated with
   the main closure without having to include '_getMainClosure()' in the list
   of embedder specified entry points
4. Get rid of the hack in kernel reader to do a delayed patch of
   '_getMainClosure()' in the builtin library.

BUG=
==========

to

==========
1. Dynamically compute the main closure that needs to be run by the main isolate
2. Get rid of _getMainClosure()
3. Adjust the AOT compiler to ensure it retains the function associated with
   the main closure without having to include '_getMainClosure()' in the list
   of embedder specified entry points
4. Get rid of the hack in kernel reader to do a delayed patch of
   '_getMainClosure()' in the builtin library.

BUG=
R=aam@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8b7af73daafedacf0f239d17096703420937af69
==========

[siva, 2017-06-15 17:40:50]

Committed patchset #4 (id:60001) manually as
8b7af73daafedacf0f239d17096703420937af69 (presubmit successful).

[karlklose, 2017-06-16 08:39:02]

karlklose@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2017-06-16 08:39:03]

https://codereview.chromium.org/2933603002/diff/60001/tests/co19/co19-kernel....
File tests/co19/co19-kernel.status (left):

https://codereview.chromium.org/2933603002/diff/60001/tests/co19/co19-kernel....
tests/co19/co19-kernel.status:119:
Language/Libraries_and_Scripts/Scripts/top_level_main_t05: Crash
This test still crashes in debug mode (see
https://codereview.chromium.org/2945573002/)