Issue 293353004: Remove HType::HeapNumber from mutable heap numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293353004: Remove HType::HeapNumber from mutable heap numbers. (Closed)

Created:
6 years, 7 months ago by Toon Verwaest

Modified:
6 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove HType::HeapNumber from mutable heap numbers. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21516

Patch Set 2 : Addressed comment #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	src/hydrogen.cc	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download
	M	src/hydrogen-instructions.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (if it is performance neutral). https://codereview.chromium.org/293353004/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/293353004/diff/1/src/hydrogen.cc#newcode5488 src/hydrogen.cc:5488: HType::Tagged(), nit: Maybe ...

6 years, 7 months ago (2014-05-26 17:38:08 UTC) #2

Toon Verwaest

6 years, 7 months ago (2014-05-27 09:40:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21516 (presubmit successful).

Expand Messages | Collapse Messages

Issue 293353004: Remove HType::HeapNumber from mutable heap numbers. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment #

Messages