Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: recipe_modules/step/config.py

Issue 2933473002: [context] Split "env" values and prefixes. (Closed)
Patch Set: plumb pathsep through so we don't assume OS Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« recipe_modules/context/tests/env.py ('K') | « recipe_modules/step/api.py ('k') | recipe_modules/step/tests/inject_paths.expected/with_value.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/step/config.py
diff --git a/recipe_modules/step/config.py b/recipe_modules/step/config.py
index 031ceb556c5ce2b5601702be033cce68f38f1578..8a155b5fbea3d1fc63df45dd795a3c15700b93e9 100644
--- a/recipe_modules/step/config.py
+++ b/recipe_modules/step/config.py
@@ -24,8 +24,11 @@ def BaseConfig(**_kwargs):
timeout = Single(int, required=False),
# optional
+ env_prefixes = Dict(value_type=List((basestring,int,Path,type(None))),
+ item_fn=lambda (k, v): (k, [str(e) for e in (v or ())] or None)),
env = Dict(item_fn=lambda (k, v): (k, v if v is None else str(v)),
value_type=(basestring,int,Path,type(None))),
+ pathsep = Single(str, required=True),
cwd = Single(Path, jsonish_fn=str, required=True),
stdout = Single(Placeholder, required=False),
« recipe_modules/context/tests/env.py ('K') | « recipe_modules/step/api.py ('k') | recipe_modules/step/tests/inject_paths.expected/with_value.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698