Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: recipe_modules/step/api.py

Issue 2933473002: [context] Split "env" values and prefixes. (Closed)
Patch Set: plumb pathsep through so we don't assume OS Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: recipe_modules/step/api.py
diff --git a/recipe_modules/step/api.py b/recipe_modules/step/api.py
index 4a250c1b057290e7cebcc247be4c41c866297e16..9e831f75d97fb3b46e8cfcfba29894e050eb88ea 100644
--- a/recipe_modules/step/api.py
+++ b/recipe_modules/step/api.py
@@ -187,12 +187,11 @@ class StepApi(recipe_api.RecipeApiPlain):
cwd = self.m.context.cwd
if cwd is not None and cwd != self.m.path['start_dir']:
kwargs['cwd'] = cwd
+
+ with self.m.context(env_prefixes={'PATH': self._prefix_path}):
+ kwargs['env_prefixes'] = self.m.context.env_prefixes
kwargs['env'] = self.m.context.env
- if self._prefix_path:
- ps = self.m.path.pathsep
- prefix = ps.join(self._prefix_path)
- suffix = kwargs['env'].get('PATH', '%(PATH)s')
- kwargs['env']['PATH'] = '%s%s%s' % (prefix, ps, suffix)
+ kwargs['pathsep'] = self.m.path.pathsep
kwargs['infra_step'] = self.m.context.infra_step or bool(infra_step)
kwargs['step_nest_level'] = self.m.context.nest_level
kwargs['name'] = full_name

Powered by Google App Engine
This is Rietveld 408576698