chrome/browser/chrome_content_browser_client.cc - Issue 2933343002: Deduplicate Monochrome locale .paks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2933343002: Deduplicate Monochrome locale .paks (Closed)

Patch Set: Addressing comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 1b93edbce9e184fb16a0e9e542b06ae2dabebc6f..426b52432429582c99a78a36a8df91c4d5d41148 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -2792,6 +2792,12 @@ void ChromeContentBrowserClient::GetAdditionalMappedFilesForChildProcess(

fd = ui::GetLocalePackFd(&region);

mappings->ShareWithRegion(kAndroidLocalePakDescriptor, fd, region);

+ // Optional secondary locale .pak file.

+ fd = ui::GetSecondaryLocalePackFd(&region);

+ if (fd != -1) {

+ mappings->ShareWithRegion(kAndroidSecondaryLocalePakDescriptor, fd, region);

+ }

breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(

child_process_id, mappings);