Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Side by Side Diff: chrome/android/BUILD.gn

Issue 2933343002: Deduplicate Monochrome locale .paks (Closed)
Patch Set: Addressing comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//base/android/jni_generator/jni_exception_list.gni") 5 import("//base/android/jni_generator/jni_exception_list.gni")
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 import("//build/util/process_version.gni") 8 import("//build/util/process_version.gni")
9 import("//chrome/android/chrome_public_apk_tmpl.gni") 9 import("//chrome/android/chrome_public_apk_tmpl.gni")
10 import("//chrome/android/monochrome_android_manifest_jinja_variables.gni") 10 import("//chrome/android/monochrome_android_manifest_jinja_variables.gni")
(...skipping 23 matching lines...) Expand all
34 34
35 chrome_sync_shell_jinja_variables = 35 chrome_sync_shell_jinja_variables =
36 default_chrome_public_jinja_variables + 36 default_chrome_public_jinja_variables +
37 [ "manifest_package=org.chromium.chrome.sync_shell" ] 37 [ "manifest_package=org.chromium.chrome.sync_shell" ]
38 38
39 app_hooks_impl = "java/src/org/chromium/chrome/browser/AppHooksImpl.java" 39 app_hooks_impl = "java/src/org/chromium/chrome/browser/AppHooksImpl.java"
40 40
41 if (enable_resource_whitelist_generation) { 41 if (enable_resource_whitelist_generation) {
42 monochrome_resource_whitelist = 42 monochrome_resource_whitelist =
43 "$target_gen_dir/monochrome_resource_whitelist.txt" 43 "$target_gen_dir/monochrome_resource_whitelist.txt"
44 monochrome_locale_whitelist =
45 "$target_gen_dir/monochrome_locale_whitelist.txt"
44 } 46 }
45 47
46 jinja_template("chrome_public_android_manifest") { 48 jinja_template("chrome_public_android_manifest") {
47 input = "java/AndroidManifest.xml" 49 input = "java/AndroidManifest.xml"
48 output = chrome_public_android_manifest 50 output = chrome_public_android_manifest
49 variables = chrome_public_jinja_variables 51 variables = chrome_public_jinja_variables
50 variables += [ 52 variables += [
51 "min_sdk_version=16", 53 "min_sdk_version=16",
52 "target_sdk_version=23", 54 "target_sdk_version=23",
53 ] 55 ]
(...skipping 670 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 _fat_lib_toolchain = android_secondary_abi_toolchain 726 _fat_lib_toolchain = android_secondary_abi_toolchain
725 } 727 }
726 deps = [ 728 deps = [
727 ":monochrome($_fat_lib_toolchain)", 729 ":monochrome($_fat_lib_toolchain)",
728 ] 730 ]
729 731
730 input = get_label_info(deps[0], "root_out_dir") + 732 input = get_label_info(deps[0], "root_out_dir") +
731 "/libmonochrome$shlib_extension.whitelist" 733 "/libmonochrome$shlib_extension.whitelist"
732 output = monochrome_resource_whitelist 734 output = monochrome_resource_whitelist
733 } 735 }
736
737 action("monochrome_locale_whitelist") {
738 script = "//tools/resources/filter_resource_whitelist.py"
739
740 _system_webview_pak_whitelist =
741 "$root_gen_dir/android_webview/system_webview_pak_whitelist.txt"
742
743 inputs = [
744 monochrome_resource_whitelist,
745 _system_webview_pak_whitelist,
746 ]
747
748 outputs = [
749 monochrome_locale_whitelist,
750 ]
751
752 deps = [
753 ":monochrome_resource_whitelist",
754 "//android_webview:system_webview_pak_whitelist",
755 ]
756
757 args = [
758 "--input",
759 rebase_path(monochrome_resource_whitelist, root_build_dir),
760 "--filter",
761 rebase_path(_system_webview_pak_whitelist, root_build_dir),
762 "--output",
763 rebase_path(monochrome_locale_whitelist, root_build_dir),
764 ]
765 }
734 } 766 }
735 767
736 # This target does not output locale paks.
737 chrome_paks("monochrome_paks") { 768 chrome_paks("monochrome_paks") {
738 output_dir = "$target_gen_dir/$target_name" 769 output_dir = "$target_gen_dir/$target_name"
739 770
740 additional_extra_paks = [ "$root_gen_dir/android_webview/aw_resources.pak" ] 771 additional_extra_paks = [ "$root_gen_dir/android_webview/aw_resources.pak" ]
741 deps = [ 772 deps = [
742 "//android_webview:generate_aw_resources", 773 "//android_webview:generate_aw_resources",
743 ] 774 ]
744 775
745 exclude_locale_paks = true
746
747 if (enable_resource_whitelist_generation) { 776 if (enable_resource_whitelist_generation) {
748 repack_whitelist = monochrome_resource_whitelist 777 repack_whitelist = monochrome_resource_whitelist
749 deps += [ ":monochrome_resource_whitelist" ] 778 deps += [ ":monochrome_resource_whitelist" ]
779 locale_whitelist = monochrome_locale_whitelist
780 deps += [ ":monochrome_locale_whitelist" ]
750 } 781 }
751 } 782 }
783
784 # This target is separate from monochrome_pak_assets because it does not
785 # disable compression.
786 android_assets("monochrome_locale_pak_assets") {
787 sources = []
788 foreach(_locale, locales - android_chrome_omitted_locales) {
789 sources += [ "$target_gen_dir/monochrome_paks/locales/$_locale.pak" ]
790 }
791
792 deps = [
793 ":monochrome_paks",
794 ]
795 }
752 796
753 # This target explicitly includes locale paks via deps. 797 # This target explicitly includes locale paks via deps.
754 android_assets("monochrome_pak_assets") { 798 android_assets("monochrome_pak_assets") {
755 sources = [ 799 sources = [
756 "$target_gen_dir/monochrome_paks/chrome_100_percent.pak", 800 "$target_gen_dir/monochrome_paks/chrome_100_percent.pak",
757 "$target_gen_dir/monochrome_paks/resources.pak", 801 "$target_gen_dir/monochrome_paks/resources.pak",
758 ] 802 ]
759 disable_compression = true 803 disable_compression = true
760 804
761 deps = [ 805 deps = [
762 ":chrome_public_locale_pak_assets", 806 ":monochrome_locale_pak_assets",
763 ":monochrome_paks", 807 ":monochrome_paks",
764 "//android_webview:locale_pak_assets", 808 "//android_webview:locale_pak_assets",
765 ] 809 ]
766 } 810 }
767 } # current_toolchain == host_toolchain 811 } # current_toolchain == host_toolchain
768 812
769 # 813 #
770 # Only 32-bit //chrome/android/monochrome is needed, beside 814 # Only 32-bit //chrome/android/monochrome is needed, beside
771 # being built with 32-bit default toolchain, it is also built 815 # being built with 32-bit default toolchain, it is also built
772 # with secondary 32-bit toolchain in 64-bit platform because we 816 # with secondary 32-bit toolchain in 64-bit platform because we
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
1031 "//components/sync:test_support_proto_java", 1075 "//components/sync:test_support_proto_java",
1032 "//components/sync/android:sync_java", 1076 "//components/sync/android:sync_java",
1033 "//content/public/android:content_java", 1077 "//content/public/android:content_java",
1034 "//content/public/test/android:content_java_test_support", 1078 "//content/public/test/android:content_java_test_support",
1035 "//third_party/android_support_test_runner:runner_java", 1079 "//third_party/android_support_test_runner:runner_java",
1036 "//third_party/android_tools:android_support_v7_appcompat_java", 1080 "//third_party/android_tools:android_support_v7_appcompat_java",
1037 "//ui/android:ui_java", 1081 "//ui/android:ui_java",
1038 ] 1082 ]
1039 proguard_enabled = !is_java_debug 1083 proguard_enabled = !is_java_debug
1040 } 1084 }
OLDNEW
« no previous file with comments | « no previous file | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698