Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Side by Side Diff: chrome/android/BUILD.gn

Issue 2933343002: Deduplicate Monochrome locale .paks (Closed)
Patch Set: Addressing comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_main_delegate.cc » ('j') | chrome/app/chrome_main_delegate.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/android/rules.gni") 6 import("//build/config/android/rules.gni")
7 import("//build/util/process_version.gni") 7 import("//build/util/process_version.gni")
8 import("//chrome/android/chrome_public_apk_tmpl.gni") 8 import("//chrome/android/chrome_public_apk_tmpl.gni")
9 import("//chrome/android/monochrome_android_manifest_jinja_variables.gni") 9 import("//chrome/android/monochrome_android_manifest_jinja_variables.gni")
10 import("//chrome/chrome_paks.gni") 10 import("//chrome/chrome_paks.gni")
(...skipping 22 matching lines...) Expand all
33 33
34 chrome_sync_shell_jinja_variables = 34 chrome_sync_shell_jinja_variables =
35 default_chrome_public_jinja_variables + 35 default_chrome_public_jinja_variables +
36 [ "manifest_package=org.chromium.chrome.sync_shell" ] 36 [ "manifest_package=org.chromium.chrome.sync_shell" ]
37 37
38 app_hooks_impl = "java/src/org/chromium/chrome/browser/AppHooksImpl.java" 38 app_hooks_impl = "java/src/org/chromium/chrome/browser/AppHooksImpl.java"
39 39
40 if (enable_resource_whitelist_generation) { 40 if (enable_resource_whitelist_generation) {
41 monochrome_resource_whitelist = 41 monochrome_resource_whitelist =
42 "$target_gen_dir/monochrome_resource_whitelist.txt" 42 "$target_gen_dir/monochrome_resource_whitelist.txt"
43 monochrome_locale_whitelist =
44 "$target_gen_dir/monochrome_locale_whitelist.txt"
43 } 45 }
44 46
45 jinja_template("chrome_public_android_manifest") { 47 jinja_template("chrome_public_android_manifest") {
46 input = "java/AndroidManifest.xml" 48 input = "java/AndroidManifest.xml"
47 output = chrome_public_android_manifest 49 output = chrome_public_android_manifest
48 variables = chrome_public_jinja_variables 50 variables = chrome_public_jinja_variables
49 variables += [ 51 variables += [
50 "min_sdk_version=16", 52 "min_sdk_version=16",
51 "target_sdk_version=23", 53 "target_sdk_version=23",
52 ] 54 ]
(...skipping 664 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 _fat_lib_toolchain = android_secondary_abi_toolchain 719 _fat_lib_toolchain = android_secondary_abi_toolchain
718 } 720 }
719 deps = [ 721 deps = [
720 ":monochrome($_fat_lib_toolchain)", 722 ":monochrome($_fat_lib_toolchain)",
721 ] 723 ]
722 724
723 input = get_label_info(deps[0], "root_out_dir") + 725 input = get_label_info(deps[0], "root_out_dir") +
724 "/libmonochrome$shlib_extension.whitelist" 726 "/libmonochrome$shlib_extension.whitelist"
725 output = monochrome_resource_whitelist 727 output = monochrome_resource_whitelist
726 } 728 }
729
730 action("monochrome_locale_whitelist") {
731 script = "//tools/resources/filter_resource_whitelist.py"
732
733 _system_webview_pak_whitelist =
734 "$root_gen_dir/android_webview/system_webview_pak_whitelist.txt"
735
736 inputs = [
737 monochrome_resource_whitelist,
738 _system_webview_pak_whitelist,
739 ]
740
741 outputs = [
742 monochrome_locale_whitelist,
743 ]
744
745 deps = [
746 ":monochrome_resource_whitelist",
747 "//android_webview:system_webview_pak_whitelist",
748 ]
749
750 args = [
751 "--input",
752 rebase_path(monochrome_resource_whitelist, root_build_dir),
753 "--filter",
754 rebase_path(_system_webview_pak_whitelist, root_build_dir),
755 "--output",
756 rebase_path(monochrome_locale_whitelist, root_build_dir),
757 "--output-directory=.",
758 ]
759 }
727 } 760 }
728 761
729 # This target does not output locale paks.
730 chrome_paks("monochrome_paks") { 762 chrome_paks("monochrome_paks") {
731 output_dir = "$target_gen_dir/$target_name" 763 output_dir = "$target_gen_dir/$target_name"
732 764
733 additional_extra_paks = [ "$root_gen_dir/android_webview/aw_resources.pak" ] 765 additional_extra_paks = [ "$root_gen_dir/android_webview/aw_resources.pak" ]
734 deps = [ 766 deps = [
735 "//android_webview:generate_aw_resources", 767 "//android_webview:generate_aw_resources",
736 ] 768 ]
737 769
738 exclude_locale_paks = true
739
740 if (enable_resource_whitelist_generation) { 770 if (enable_resource_whitelist_generation) {
741 repack_whitelist = monochrome_resource_whitelist 771 repack_whitelist = monochrome_resource_whitelist
742 deps += [ ":monochrome_resource_whitelist" ] 772 deps += [ ":monochrome_resource_whitelist" ]
773 locale_whitelist = monochrome_locale_whitelist
774 deps += [ ":monochrome_locale_whitelist" ]
743 } 775 }
744 } 776 }
777
778 # This target is separate from monochrome_pak_assets because it does not
779 # disable compression.
780 android_assets("monochrome_locale_pak_assets") {
781 sources = []
782 foreach(_locale, locales - android_chrome_omitted_locales) {
783 sources += [ "$target_gen_dir/monochrome_paks/locales/$_locale.pak" ]
784 }
785
786 deps = [
787 ":monochrome_paks",
788 ]
789 }
745 790
746 # This target explicitly includes locale paks via deps. 791 # This target explicitly includes locale paks via deps.
747 android_assets("monochrome_pak_assets") { 792 android_assets("monochrome_pak_assets") {
748 sources = [ 793 sources = [
749 "$target_gen_dir/monochrome_paks/chrome_100_percent.pak", 794 "$target_gen_dir/monochrome_paks/chrome_100_percent.pak",
750 "$target_gen_dir/monochrome_paks/resources.pak", 795 "$target_gen_dir/monochrome_paks/resources.pak",
751 ] 796 ]
752 disable_compression = true 797 disable_compression = true
753 798
754 deps = [ 799 deps = [
755 ":chrome_public_locale_pak_assets", 800 ":monochrome_locale_pak_assets",
756 ":monochrome_paks", 801 ":monochrome_paks",
757 "//android_webview:locale_pak_assets", 802 "//android_webview:locale_pak_assets",
758 ] 803 ]
759 } 804 }
760 } # current_toolchain == host_toolchain 805 } # current_toolchain == host_toolchain
761 806
762 # 807 #
763 # Only 32-bit //chrome/android/monochrome is needed, beside 808 # Only 32-bit //chrome/android/monochrome is needed, beside
764 # being built with 32-bit default toolchain, it is also built 809 # being built with 32-bit default toolchain, it is also built
765 # with secondary 32-bit toolchain in 64-bit platform because we 810 # with secondary 32-bit toolchain in 64-bit platform because we
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
1019 apk_name = "ChromeSyncShellTest" 1064 apk_name = "ChromeSyncShellTest"
1020 apk_under_test = ":chrome_sync_shell_apk" 1065 apk_under_test = ":chrome_sync_shell_apk"
1021 android_manifest = chrome_sync_shell_test_apk_manifest 1066 android_manifest = chrome_sync_shell_test_apk_manifest
1022 android_manifest_dep = ":chrome_sync_shell_test_apk_manifest" 1067 android_manifest_dep = ":chrome_sync_shell_test_apk_manifest"
1023 deps = [ 1068 deps = [
1024 ":chrome_sync_shell_test_apk_java", 1069 ":chrome_sync_shell_test_apk_java",
1025 "//third_party/android_support_test_runner:runner_java", 1070 "//third_party/android_support_test_runner:runner_java",
1026 ] 1071 ]
1027 proguard_enabled = !is_java_debug 1072 proguard_enabled = !is_java_debug
1028 } 1073 }
OLDNEW
« no previous file with comments | « no previous file | chrome/app/chrome_main_delegate.cc » ('j') | chrome/app/chrome_main_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698