content/browser/devtools/devtools_agent_host_impl.h - Issue 2933243002: [DevTools] Make DevToolsSession own it's DevToolsMessageChunkProcessor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 2933243002: [DevTools] Make DevToolsSession own it's DevToolsMessageChunkProcessor (Closed)

Patch Set: more concise Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/devtools_agent_host_impl.h

diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h

index 774c925a8d9f0fa5ab56a26d7a197fb52ac73548..6b2a7851949819e230bdcce6f83aa212c29478dd 100644

--- a/content/browser/devtools/devtools_agent_host_impl.h

+++ b/content/browser/devtools/devtools_agent_host_impl.h

@@ -91,7 +91,7 @@ class DevToolsMessageChunkProcessor {

explicit DevToolsMessageChunkProcessor(const SendMessageCallback& callback);

~DevToolsMessageChunkProcessor();

- std::string state_cookie() const { return state_cookie_; }

+ const std::string& state_cookie() const { return state_cookie_; }

void set_state_cookie(const std::string& cookie) { state_cookie_ = cookie; }

int last_call_id() const { return last_call_id_; }

bool ProcessChunkedMessageFromAgent(const DevToolsMessageChunk& chunk);