Update subclasses array and is_implemented bit when loading script snapshots.

runtime/vm/snapshot_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 
 #include "include/dart_tools_api.h"
 #include "platform/assert.h"
 #include "vm/class_finalizer.h"
 #include "vm/clustered_snapshot.h"
@@ skipping 984 matching lines @@
 
   // Check if we are able to generate the source from the token stream.
   // Rescan this source and compare the token stream to see if they are
   // the same.
   GenerateSourceAndCheck(serialized_script);
 
   free(buffer);
 }
 
 
-#if !defined(PRODUCT)  // Uses deferred loading.
 VM_UNIT_TEST_CASE(CanonicalizationInScriptSnapshots) {

[siva, 2017/06/12 22:59:42]

The comment for !defined(PRODUCT) is incorrect, I believe it not defined for
product because the test uses mirrors (dart::mirrors).

Maybe you can get rid of "import 'dart:mirrors';" doesn't seem to be used in the
test.

[rmacnak, 2017/06/12 23:37:42]

It uses reflectClass. Updated comment instead.

   const char* kScriptChars =
       "\n"
       "import 'dart:mirrors';"
       "import 'dart:isolate';"
       "void main() {"
       "  if (reflectClass(MyException).superclass.reflectedType != "
       "      IsolateSpawnException) {"
       "    throw new Exception('Canonicalization failure');"
       "  }"
       "  if (reflectClass(IsolateSpawnException).reflectedType != "
       "      IsolateSpawnException) {"
       "    throw new Exception('Canonicalization failure');"
       "  }"
       "}\n"
       "class MyException extends IsolateSpawnException {}"
       "\n";
 
   Dart_Handle result;
 
   uint8_t* buffer;
   intptr_t size;
   intptr_t vm_isolate_snapshot_size;
   uint8_t* isolate_snapshot = NULL;
   intptr_t isolate_snapshot_size;
   uint8_t* full_snapshot = NULL;
   uint8_t* script_snapshot = NULL;
 
+#if !defined(PRODUCT)
   bool saved_load_deferred_eagerly_mode = FLAG_load_deferred_eagerly;
   FLAG_load_deferred_eagerly = true;
+#endif
   {
     // Start an Isolate, and create a full snapshot of it.
     TestIsolateScope __test_isolate__;
     Dart_EnterScope();  // Start a Dart API scope for invoking API functions.
 
     // Write out the script snapshot.
     result = Dart_CreateSnapshot(NULL, &vm_isolate_snapshot_size,
                                  &isolate_snapshot, &isolate_snapshot_size);
     EXPECT_VALID(result);
     full_snapshot = reinterpret_cast<uint8_t*>(malloc(isolate_snapshot_size));
     memmove(full_snapshot, isolate_snapshot, isolate_snapshot_size);
     Dart_ExitScope();
   }
+#if !defined(PRODUCT)
   FLAG_load_deferred_eagerly = saved_load_deferred_eagerly_mode;
+#endif
 
   {
     // Now Create an Isolate using the full snapshot and load the
     // script  and execute it.
     TestCase::CreateTestIsolateFromSnapshot(full_snapshot);
     Dart_EnterScope();  // Start a Dart API scope for invoking API functions.
 
     // Create a test library and Load up a test script in it.
     Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
 
@@ skipping 39 matching lines @@
 
     // Invoke a function which returns an object.
     result = Dart_Invoke(result, NewString("main"), 0, NULL);
     EXPECT_VALID(result);
     Dart_ExitScope();
     Dart_ShutdownIsolate();
   }
   free(script_snapshot);
   free(full_snapshot);
 }
+
+
+VM_UNIT_TEST_CASE(ScriptSnapshotsUpdateSubclasses) {
+  const char* kScriptChars =
+      "class _DebugDuration extends Duration {\n"
+      "  const _DebugDuration() : super(milliseconds: 42);\n"
+      "}\n"
+      "foo(x, y) {\n"
+      "  for (var i = 0; i < 1000000; i++) {\n"
+      "    if (x != y) {\n"
+      "      throw 'Boom!';\n"
+      "    }\n"
+      "  }\n"
+      "}\n"
+      "main() {\n"
+      "  final v = const Duration(milliseconds: 42);\n"
+      "  foo(v, new _DebugDuration());\n"
+      "}\n"
+      "\n";
+
+  Dart_Handle result;
+
+  uint8_t* buffer;
+  intptr_t size;
+  intptr_t vm_isolate_snapshot_size;
+  uint8_t* isolate_snapshot = NULL;
+  intptr_t isolate_snapshot_size;
+  uint8_t* full_snapshot = NULL;
+  uint8_t* script_snapshot = NULL;
+
+#if !defined(PRODUCT)
+  bool saved_load_deferred_eagerly_mode = FLAG_load_deferred_eagerly;
+  FLAG_load_deferred_eagerly = true;
 #endif
+  intptr_t saved_max_polymorphic_checks = FLAG_max_polymorphic_checks;
+  FLAG_max_polymorphic_checks = 0;
+
+  {
+    // Start an Isolate, and create a full snapshot of it.
+    TestIsolateScope __test_isolate__;
+    Dart_EnterScope();  // Start a Dart API scope for invoking API functions.
+
+    // Write out the script snapshot.
+    result = Dart_CreateSnapshot(NULL, &vm_isolate_snapshot_size,
+                                 &isolate_snapshot, &isolate_snapshot_size);
+    EXPECT_VALID(result);
+    full_snapshot = reinterpret_cast<uint8_t*>(malloc(isolate_snapshot_size));
+    memmove(full_snapshot, isolate_snapshot, isolate_snapshot_size);
+    Dart_ExitScope();
+  }
+
+  {
+    // Now Create an Isolate using the full snapshot and load the
+    // script  and execute it.
+    TestCase::CreateTestIsolateFromSnapshot(full_snapshot);
+    Dart_EnterScope();  // Start a Dart API scope for invoking API functions.
+
+    // Create a test library and Load up a test script in it.
+    Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
+
+    EXPECT_VALID(lib);
+
+    // Invoke a function which returns an object.
+    result = Dart_Invoke(lib, NewString("main"), 0, NULL);
+    EXPECT_VALID(result);
+    Dart_ExitScope();
+    Dart_ShutdownIsolate();
+  }
+
+  {
+    // Create an Isolate using the full snapshot, load a script and create
+    // a script snapshot of the script.
+    TestCase::CreateTestIsolateFromSnapshot(full_snapshot);
+    Dart_EnterScope();  // Start a Dart API scope for invoking API functions.
+
+    // Create a test library and Load up a test script in it.
+    TestCase::LoadTestScript(kScriptChars, NULL);
+
+    EXPECT_VALID(Api::CheckAndFinalizePendingClasses(Thread::Current()));
+
+    // Write out the script snapshot.
+    result = Dart_CreateScriptSnapshot(&buffer, &size);
+    EXPECT_VALID(result);
+    script_snapshot = reinterpret_cast<uint8_t*>(malloc(size));
+    memmove(script_snapshot, buffer, size);
+    Dart_ExitScope();
+    Dart_ShutdownIsolate();
+  }
+
+  {
+    // Now Create an Isolate using the full snapshot and load the
+    // script snapshot created above and execute it.
+    TestCase::CreateTestIsolateFromSnapshot(full_snapshot);
+    Dart_EnterScope();  // Start a Dart API scope for invoking API functions.
+
+    // Load the test library from the snapshot.
+    EXPECT(script_snapshot != NULL);
+    result = Dart_LoadScriptFromSnapshot(script_snapshot, size);
+    EXPECT_VALID(result);
+
+    // Invoke a function which returns an object.
+    result = Dart_Invoke(result, NewString("main"), 0, NULL);
+    EXPECT_VALID(result);
+    Dart_ExitScope();
+    Dart_ShutdownIsolate();
+  }
+  free(script_snapshot);
+  free(full_snapshot);
+
+  FLAG_max_polymorphic_checks = saved_max_polymorphic_checks;
+#if !defined(PRODUCT)
+  FLAG_load_deferred_eagerly = saved_load_deferred_eagerly_mode;
+#endif
+}
 
 
 static void IterateScripts(const Library& lib) {
   const Array& lib_scripts = Array::Handle(lib.LoadedScripts());
   Script& script = Script::Handle();
   String& uri = String::Handle();
   for (intptr_t i = 0; i < lib_scripts.Length(); i++) {
     script ^= lib_scripts.At(i);
     EXPECT(!script.IsNull());
     uri = script.url();
@@ skipping 1892 matching lines @@
   StackZone zone(Thread::Current());
   uint8_t* buffer;
   MessageWriter writer(&buffer, &zone_allocator, &zone_deallocator, true);
   writer.WriteInlinedObjectHeader(kOmittedObjectId);
   // For performance, we'd like single-byte headers when ids are omitted.
   // If this starts failing, consider renumbering the snapshot ids.
   EXPECT_EQ(1, writer.BytesWritten());
 }
 
 }  // namespace dart