Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5822)

Unified Diff: chrome/browser/offline_pages/background_loader_offliner.h

Issue 2933193003: Headers for resource tracking. (Closed)
Patch Set: Continue rename Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/offline_pages/background_loader_offliner.h
diff --git a/chrome/browser/offline_pages/background_loader_offliner.h b/chrome/browser/offline_pages/background_loader_offliner.h
index 0acbff3567d45432c1e1091514a5978764cb64d8..7de72721bc1daa8968bb1b6c4b82a08bb6270ea8 100644
--- a/chrome/browser/offline_pages/background_loader_offliner.h
+++ b/chrome/browser/offline_pages/background_loader_offliner.h
@@ -9,6 +9,7 @@
#include "base/memory/weak_ptr.h"
#include "base/values.h"
+#include "chrome/browser/offline_pages/resource_loading_observer.h"
#include "components/offline_pages/content/background_loader/background_loader_contents.h"
#include "components/offline_pages/core/background/load_termination_listener.h"
#include "components/offline_pages/core/background/offliner.h"
@@ -30,7 +31,8 @@ class OfflinePageModel;
// OfflinePageModel to save it. Only one request may be active at a time.
class BackgroundLoaderOffliner : public Offliner,
public content::WebContentsObserver,
- public SnapshotController::Client {
+ public SnapshotController::Client,
+ public ResourceLoadingObserver {
public:
BackgroundLoaderOffliner(
content::BrowserContext* browser_context,
@@ -63,7 +65,11 @@ class BackgroundLoaderOffliner : public Offliner,
void SetSnapshotControllerForTest(
std::unique_ptr<SnapshotController> controller);
- void OnNetworkBytesChanged(int64_t bytes);
+
+ // ResourceTrackerObserver implemenation
RyanSturm 2017/06/16 17:04:45 s/ResourceTrackerObserver/ResourceLoadingObserver/
Pete Williamson 2017/06/16 21:16:15 Done.
+ void ObserveResourceLoading(ResourceLoadingObserver::ResourceDataType type,
RyanSturm 2017/06/16 17:04:44 Is this called from anywhere? If not, would it mak
Pete Williamson 2017/06/16 21:16:15 Not done. The intent of this changelist is to giv
+ bool started) override;
+ void OnNetworkBytesChanged(int64_t bytes) override;
protected:
// Called to reset the loader.

Powered by Google App Engine
This is Rietveld 408576698