[WIP] Fix periodic dumping for memory-infra on Android.

tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html

Index: tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
diff --git a/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html b/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
index 0971bb93c1395a7f0d40c2a79229bfe811119706..ac183974ad10d0683ee5cce3cef2e8d13eb55e52 100644
--- a/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
+++ b/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
@@ -91,14 +91,22 @@ tr.exportTo('tr.ui.e.about_tracing', function() {
         throw new Error('Already recording');
       }
       this.recording_ = 'starting';
+      var memory_config = { triggers: [] };
+      if (recordingOptions.includedCategories.indexOf('disabled-by-default-memory-infra') !== -1) {
+          memory_config.triggers.push(
+            {'mode': 'detailed', 'periodic_interval_ms': 10000});
+      }
+      var trace_config_str = {
+          includedCategories: recordingOptions.includedCategories,
+          excludedCategories: recordingOptions.excludedCategories,
+          memoryDumpConfig: memory_config,
+          recordMode: "record-until-full"
+      };
+      alert(recordingOptions.tracingRecordMode);
       let res = this.conn_.req(
           'Tracing.start',
           {
-            categories: recordingOptions.categoryFilter,
-            options:
-                [recordingOptions.tracingRecordMode,
-                  (recordingOptions.useSampling ? 'enable-sampling' : '')

[fmeawad, 2017/06/14 17:18:36]

This was for the old sampling code that was removed?

[ssid, 2017/06/21 18:38:16]

Sorry this should be fixed in Eirk's cl.

-                ].join(','),
+            traceConfig: trace_config_str,

[fmeawad, 2017/06/14 17:18:36]

Should we be concerned about the string size? give that we list all the
categories?

[ssid, 2017/06/21 18:38:16]

I think it was the same earlier as well. We used to add category filter with all
category names and exlcluded ones with '-'. So, size should not very much.

             bufferUsageReportingInterval: 1000
           });
       res = res.then(