Chromium Code Reviews| Index: chrome/browser/predictors/loading_data_collector.h |
| diff --git a/chrome/browser/predictors/loading_data_collector.h b/chrome/browser/predictors/loading_data_collector.h |
| index 65274eef91284820edce6fbc3a8a1dbd26af836e..cb5c3217ae2c51a8e283571e36ed1713c5d4dd94 100644 |
| --- a/chrome/browser/predictors/loading_data_collector.h |
| +++ b/chrome/browser/predictors/loading_data_collector.h |
| @@ -16,14 +16,13 @@ class URLRequest; |
| namespace predictors { |
| -// Records navigation events as reported by various observers to the database |
| -// and stats collection classes. All the non-static methods of this class need |
| +// Records to the database and stats collection classes navigation events as |
| +// reported by various observers. All the non-static methods of this class need |
|
trevordixon
2017/06/13 11:50:49
In response to this comment from pasko on a previo
pasko
2017/06/13 12:53:28
Yes, it makes it much clearer, thank you.
|
| // to be called on the UI thread. |
| class LoadingDataCollector |
| : public base::SupportsWeakPtr<LoadingDataCollector> { |
| public: |
| - explicit LoadingDataCollector( |
| - predictors::ResourcePrefetchPredictor* predictor); |
| + explicit LoadingDataCollector(ResourcePrefetchPredictor* predictor); |
|
trevordixon
2017/06/13 11:50:49
Got rid of unnecessary predictors:: namespace spec
|
| ~LoadingDataCollector(); |
| // Thread safe. |
| @@ -37,11 +36,11 @@ class LoadingDataCollector |
| // requests. Should only be called if the corresponding Should* functions |
| // return true. |
| void RecordURLRequest( |
| - const predictors::ResourcePrefetchPredictor::URLRequestSummary& request); |
| + const ResourcePrefetchPredictor::URLRequestSummary& request); |
| void RecordURLResponse( |
| - const predictors::ResourcePrefetchPredictor::URLRequestSummary& response); |
| + const ResourcePrefetchPredictor::URLRequestSummary& response); |
| void RecordURLRedirect( |
| - const predictors::ResourcePrefetchPredictor::URLRequestSummary& response); |
| + const ResourcePrefetchPredictor::URLRequestSummary& response); |
| // Called when the main frame of a page completes loading. |
| void RecordMainFrameLoadComplete(const NavigationID& navigation_id); |
| @@ -69,7 +68,7 @@ class LoadingDataCollector |
| static void SetAllowPortInUrlsForTesting(bool state); |
| - predictors::ResourcePrefetchPredictor* const predictor_; |
| + ResourcePrefetchPredictor* const predictor_; |
| }; |
| } // namespace predictors |