[ObjC ARC] Converts ios/chrome/browser/autofill:autofill to ARC.

ios/chrome/browser/autofill/form_input_accessory_view_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/autofill/form_input_accessory_view_controller.h"
 
 #include <memory>
 
 #include "base/ios/block_types.h"
 #include "base/ios/ios_util.h"
 #include "base/mac/foundation_util.h"
 #include "base/mac/scoped_block.h"
-#include "base/mac/scoped_nsobject.h"
 #import "components/autofill/core/browser/keyboard_accessory_metrics_logger.h"
 #import "components/autofill/ios/browser/js_suggestion_manager.h"
 #import "ios/chrome/browser/autofill/form_input_accessory_view.h"
 #import "ios/chrome/browser/autofill/form_suggestion_view.h"
 #import "ios/chrome/browser/passwords/password_generation_utils.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 #import "ios/web/public/url_scheme_util.h"
 #import "ios/web/public/web_state/js/crw_js_injection_receiver.h"
 #import "ios/web/public/web_state/ui/crw_web_view_proxy.h"
 #include "ios/web/public/web_state/url_verification_constants.h"
 #include "ios/web/public/web_state/web_state.h"
 #include "url/gurl.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace autofill {
 NSString* const kFormSuggestionAssistButtonPreviousElement = @"previousTap";
 NSString* const kFormSuggestionAssistButtonNextElement = @"nextTap";
 NSString* const kFormSuggestionAssistButtonDone = @"done";
 CGFloat const kInputAccessoryHeight = 44.0f;
 }  // namespace autofill
 
 namespace {
 
 // Finds all views of a particular kind if class |klass| in the subview
@@ skipping 54 matching lines @@
   }
 
   return descendants;
 }
 
 NSArray* FindDescendantToolbarItemsForActionName(
     UITextInputAssistantItem* inputAssistantItem,
     NSString* actionName) {
   NSMutableArray* toolbarItems = [NSMutableArray array];
 
-  base::scoped_nsobject<NSMutableArray> buttonGroupsGroup(
-      [[NSMutableArray alloc] init]);
+  NSMutableArray* buttonGroupsGroup = [[NSMutableArray alloc] init];
   if (inputAssistantItem.leadingBarButtonGroups)
     [buttonGroupsGroup addObject:inputAssistantItem.leadingBarButtonGroups];
   if (inputAssistantItem.trailingBarButtonGroups)
     [buttonGroupsGroup addObject:inputAssistantItem.trailingBarButtonGroups];
-  for (NSArray* buttonGroups in buttonGroupsGroup.get()) {
+  for (NSArray* buttonGroups in buttonGroupsGroup) {
     for (UIBarButtonItemGroup* group in buttonGroups) {
       NSArray* items = group.barButtonItems;
       for (UIBarButtonItem* item in items) {
         if (ItemActionMatchesName(item, actionName))
           [toolbarItems addObject:item];
       }
     }
   }
 
   return toolbarItems;
@@ skipping 75 matching lines @@
 @end
 
 @implementation FormInputAccessoryViewController {
   // Bridge to observe the web state from Objective-C.
   std::unique_ptr<web::WebStateObserverBridge> _webStateObserverBridge;
 
   // Last registered keyboard rectangle.
   CGRect _keyboardFrame;
 
   // The custom view that should be shown in the input accessory view.
-  base::scoped_nsobject<UIView> _customAccessoryView;
+  UIView* _customAccessoryView;
 
   // The JS manager for interacting with the underlying form.
-  base::scoped_nsobject<JsSuggestionManager> _JSSuggestionManager;
+  JsSuggestionManager* _JSSuggestionManager;
 
   // The original subviews in keyboard accessory view that were originally not
   // hidden but were hidden when showing Autofill suggestions.
-  base::scoped_nsobject<NSMutableArray> _hiddenOriginalSubviews;
+  NSMutableArray* _hiddenOriginalSubviews;
 
   // The objects that can provide a custom input accessory view while filling
   // forms.
-  base::scoped_nsobject<NSArray> _providers;
+  NSArray* _providers;
 
   // Whether suggestions have previously been shown.
   BOOL _suggestionsHaveBeenShown;
 
   // The object that manages the currently-shown custom accessory view.
-  base::WeakNSProtocol<id<FormInputAccessoryViewProvider>> _currentProvider;
+  __weak id<FormInputAccessoryViewProvider> _currentProvider;
 
   // Logs UMA metrics for the keyboard accessory.
   std::unique_ptr<autofill::KeyboardAccessoryMetricsLogger>
       _keyboardAccessoryMetricsLogger;
 }
 
 - (instancetype)initWithWebState:(web::WebState*)webState
                        providers:(NSArray*)providers {
   JsSuggestionManager* suggestionManager =
       base::mac::ObjCCastStrict<JsSuggestionManager>(
           [webState->GetJSInjectionReceiver()
               instanceOfClass:[JsSuggestionManager class]]);
   return [self initWithWebState:webState
             JSSuggestionManager:suggestionManager
                       providers:providers];
 }
 
 - (instancetype)initWithWebState:(web::WebState*)webState
              JSSuggestionManager:(JsSuggestionManager*)JSSuggestionManager
                        providers:(NSArray*)providers {
   self = [super init];
   if (self) {
-    _JSSuggestionManager.reset([JSSuggestionManager retain]);
-    _hiddenOriginalSubviews.reset([[NSMutableArray alloc] init]);
+    _JSSuggestionManager = JSSuggestionManager;
+    _hiddenOriginalSubviews = [[NSMutableArray alloc] init];
     _webStateObserverBridge.reset(
         new web::WebStateObserverBridge(webState, self));
-    _providers.reset([providers copy]);
+    _providers = [providers copy];
     _suggestionsHaveBeenShown = NO;
     _keyboardAccessoryMetricsLogger.reset(
         new autofill::KeyboardAccessoryMetricsLogger());
   }
   return self;
 }
 
 - (void)wasShown {
   // There is no defined relation on the timing of JavaScript events and
   // keyboard showing up. So it is necessary to listen to the keyboard
@@ skipping 27 matching lines @@
            object:nil];
 }
 
 - (void)wasHidden {
   [_customAccessoryView removeFromSuperview];
   [[NSNotificationCenter defaultCenter] removeObserver:self];
 }
 
 - (void)dealloc {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
-  [super dealloc];
 }
 
 - (web::WebState*)webState {
   return _webStateObserverBridge ? _webStateObserverBridge->web_state()
                                  : nullptr;
 }
 
 - (id<CRWWebViewProxy>)webViewProxy {
   return self.webState ? self.webState->GetWebViewProxy() : nil;
 }
@@ skipping 11 matching lines @@
   DCHECK(view);
   if (IsIPadIdiom()) {
     // On iPads running iOS 9 or later, there's no inputAccessoryView available
     // so we attach the custom view directly to the keyboard view instead.
     [_customAccessoryView removeFromSuperview];
 
     // If the keyboard isn't visible don't show the custom view.
     if (CGRectIntersection([UIScreen mainScreen].bounds, _keyboardFrame)
                 .size.height == 0 ||
         CGRectEqualToRect(_keyboardFrame, CGRectZero)) {
-      _customAccessoryView.reset();
+      _customAccessoryView = nil;
       return;
     }
 
     // If this is a form suggestion view and no suggestions have been triggered
     // yet, don't show the custom view.
     FormSuggestionView* formSuggestionView =
         base::mac::ObjCCast<FormSuggestionView>(view);
     if (formSuggestionView) {
       int numSuggestions = [[formSuggestionView suggestions] count];
       if (!_suggestionsHaveBeenShown && numSuggestions == 0) {
-        _customAccessoryView.reset();
+        _customAccessoryView = nil;
         return;
       }
     }
     _suggestionsHaveBeenShown = YES;
 
     CGFloat height = autofill::kInputAccessoryHeight;
     CGRect contentFrame = self.webViewProxy.frame;
     CGRect frame = CGRectMake(contentFrame.origin.x, -height,
                               contentFrame.size.width, height);
-    _customAccessoryView.reset(
-        [[FormInputAccessoryView alloc] initWithFrame:frame customView:view]);
+    _customAccessoryView =
+        [[FormInputAccessoryView alloc] initWithFrame:frame customView:view];
     UIView* keyboardView = [self getKeyboardView];
     DCHECK(keyboardView);
     [keyboardView addSubview:_customAccessoryView];
   } else {
     // On all other versions, the custom view replaces the default UI of the
     // inputAccessoryView.
     [self restoreDefaultInputAccessoryView];
     CGRect leftFrame;
     CGRect rightFrame;
     UIView* inputAccessoryView = [self.webViewProxy keyboardAccessory];
     if (ComputeFramesOfKeyboardParts(inputAccessoryView, &leftFrame,
                                      &rightFrame)) {
       [self hideSubviewsInOriginalAccessoryView:inputAccessoryView];
-      _customAccessoryView.reset([[FormInputAccessoryView alloc]
-          initWithFrame:inputAccessoryView.frame
-               delegate:self
-             customView:view
-              leftFrame:leftFrame
-             rightFrame:rightFrame]);
+      _customAccessoryView =
+          [[FormInputAccessoryView alloc] initWithFrame:inputAccessoryView.frame
+                                               delegate:self
+                                             customView:view
+                                              leftFrame:leftFrame
+                                             rightFrame:rightFrame];
       [inputAccessoryView addSubview:_customAccessoryView];
     }
   }
 }
 
 - (void)restoreDefaultInputAccessoryView {
   [_customAccessoryView removeFromSuperview];
-  _customAccessoryView.reset();
-  for (UIView* subview in _hiddenOriginalSubviews.get()) {
+  _customAccessoryView = nil;
+  for (UIView* subview in _hiddenOriginalSubviews) {
     subview.hidden = NO;
   }
   [_hiddenOriginalSubviews removeAllObjects];
 }
 
 - (void)closeKeyboardWithButtonPress {
   [self closeKeyboardWithoutButtonPress];
   if (_currentProvider && [_currentProvider getLogKeyboardAccessoryMetrics])
     _keyboardAccessoryMetricsLogger->OnCloseButtonPressed();
 }
@@ skipping 23 matching lines @@
     if (!inputAccessoryView)
       return NO;
     descendants =
         FindDescendantToolbarItemsForActionName(inputAccessoryView, actionName);
   }
 
   if (![descendants count])
     return NO;
 
   UIBarButtonItem* item = descendants[0];
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Warc-performSelector-leaks"
   [[item target] performSelector:[item action] withObject:item];
+#pragma clang diagnostic pop
   return YES;
 }
 
 #pragma mark -
 #pragma mark FormInputAccessoryViewDelegate
 
 - (void)selectPreviousElementWithButtonPress {
   [self selectPreviousElementWithoutButtonPress];
   if (_currentProvider && [_currentProvider getLogKeyboardAccessoryMetrics])
     _keyboardAccessoryMetricsLogger->OnPreviousButtonPressed();
@@ skipping 68 matching lines @@
 }
 
 - (void)webStateDestroyed:(web::WebState*)webState {
   [self reset];
   _webStateObserverBridge.reset();
 }
 
 - (void)reset {
   if (_currentProvider) {
     [_currentProvider inputAccessoryViewControllerDidReset:self];
-    _currentProvider.reset();
+    _currentProvider = nil;
   }
   [self restoreDefaultInputAccessoryView];
 
   _keyboardAccessoryMetricsLogger.reset(
       new autofill::KeyboardAccessoryMetricsLogger());
 }
 
 - (void)retrieveAccessoryViewForForm:(const std::string&)formName
                                field:(const std::string&)fieldName
                                value:(const std::string&)value
                                 type:(const std::string&)type
                             webState:(web::WebState*)webState {
-  base::WeakNSObject<FormInputAccessoryViewController> weakSelf(self);
+  __weak FormInputAccessoryViewController* weakSelf = self;
   std::string strongFormName = formName;
   std::string strongFieldName = fieldName;
   std::string strongValue = value;
   std::string strongType = type;
 
   // Build a block for each provider that will invoke its completion with YES
   // if the provider can provide an accessory view for the specified form/field
   // and NO otherwise.
-  base::scoped_nsobject<NSMutableArray> findProviderBlocks(
-      [[NSMutableArray alloc] init]);
+  NSMutableArray* findProviderBlocks = [[NSMutableArray alloc] init];
   for (NSUInteger i = 0; i < [_providers count]; i++) {
-    base::mac::ScopedBlock<passwords::PipelineBlock> block(
+    passwords::PipelineBlock block =
         ^(void (^completion)(BOOL success)) {
           // Access all the providers through |self| to guarantee that both
           // |self| and all the providers exist when the block is executed.
           // |_providers| is immutable, so the subscripting is always valid.
-          base::scoped_nsobject<FormInputAccessoryViewController> strongSelf(
-              [weakSelf retain]);
+          FormInputAccessoryViewController* strongSelf = weakSelf;
           if (!strongSelf)
             return;
           id<FormInputAccessoryViewProvider> provider =
-              strongSelf.get()->_providers[i];
+              strongSelf->_providers[i];
           [provider checkIfAccessoryViewIsAvailableForFormNamed:strongFormName
                                                       fieldName:strongFieldName
                                                        webState:webState
                                               completionHandler:completion];
-        },
-        base::scoped_policy::RETAIN);
+        };
     [findProviderBlocks addObject:block];
   }
 
   // Once the view is retrieved, update the UI.
   AccessoryViewReadyCompletion readyCompletion =
       ^(UIView* accessoryView, id<FormInputAccessoryViewProvider> provider) {
-        base::scoped_nsobject<FormInputAccessoryViewController> strongSelf(
-            [weakSelf retain]);
-        if (!strongSelf || !strongSelf.get()->_currentProvider)
+        FormInputAccessoryViewController* strongSelf = weakSelf;
+        if (!strongSelf || !strongSelf->_currentProvider)
           return;
-        DCHECK_EQ(strongSelf.get()->_currentProvider.get(), provider);
+        DCHECK_EQ(strongSelf->_currentProvider, provider);
         [provider setAccessoryViewDelegate:strongSelf];
         [strongSelf showCustomInputAccessoryView:accessoryView];
       };
 
   // Once a provider is found, use it to retrieve the accessory view.
   passwords::PipelineCompletionBlock onProviderFound =
       ^(NSUInteger providerIndex) {
         if (providerIndex == NSNotFound) {
           [weakSelf reset];
           return;
         }
-        base::scoped_nsobject<FormInputAccessoryViewController> strongSelf(
-            [weakSelf retain]);
+        FormInputAccessoryViewController* strongSelf = weakSelf;
         if (!strongSelf || ![strongSelf webState])
           return;
         id<FormInputAccessoryViewProvider> provider =
-            strongSelf.get()->_providers[providerIndex];
-        [strongSelf.get()->_currentProvider
+            strongSelf->_providers[providerIndex];
+        [strongSelf->_currentProvider
             inputAccessoryViewControllerDidReset:self];
-        strongSelf.get()->_currentProvider.reset(provider);
-        [strongSelf.get()->_currentProvider
+        strongSelf->_currentProvider = provider;
+        [strongSelf->_currentProvider
             retrieveAccessoryViewForFormNamed:strongFormName
                                     fieldName:strongFieldName
                                         value:strongValue
                                          type:strongType
                                      webState:webState
                      accessoryViewUpdateBlock:readyCompletion];
       };
 
   // Run all the blocks in |findProviderBlocks| until one invokes its
   // completion with YES. The first one to do so will be passed to
@@ skipping 46 matching lines @@
 // that we don't present our custom view over the keyboard.
 - (void)textInputDidBeginEditing:(NSNotification*)notification {
   [self reset];
 }
 
 - (void)keyboardDidHide:(NSNotification*)notification {
   _keyboardFrame = CGRectZero;
 }
 
 @end