Tweak the look of the ast and element links in the diagnostics page.

Tweak the look of the ast and element links in the diagnostics page.

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/44854543eab71adbfeeca4bfd07b42e0d8667623

[devoncarew, 2017-06-12 01:54:12]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com

[devoncarew, 2017-06-12 01:54:13]

- have the ast and element links be bare (not surrounded by parans)
- add a showInNav getter to allow pages to opt-out of displaying in the nav
- use just the path for the description of the ast and element pages (which is
not full sentence structure, so mea culpa, but I think it looks better)

[Brian Wilkerson, 2017-06-12 13:36:23]

lgtm

https://codereview.chromium.org/2933043003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/diagnostics.dart (right):

https://codereview.chromium.org/2933043003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:150: _description = path;
I liked having an indication of whether I'm looking at an AST or an element
model. While I'm sure it's visually cleaner, it looses information.

[devoncarew, 2017-06-12 13:57:02]

https://codereview.chromium.org/2933043003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/diagnostics.dart (right):

https://codereview.chromium.org/2933043003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:150: _description = path;
On 2017/06/12 13:36:23, Brian Wilkerson wrote:
> I liked having an indication of whether I'm looking at an AST or an element
> model. While I'm sure it's visually cleaner, it looses information.

I'm happy to revert this, but from playing with the pages last night I think
it's clear enough where you are - both pages have 'AST' or 'Element' as the page
title right above the description.

[Brian Wilkerson, 2017-06-12 13:59:27]

https://codereview.chromium.org/2933043003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/diagnostics.dart (right):

https://codereview.chromium.org/2933043003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:150: _description = path;
I didn't remember that. As long as it's clear what I'm looking at, I guess I
don't care.

[devoncarew, 2017-06-12 14:15:43]

Description was changed from

==========
Tweak the look of the ast and element links in the diagnostics page.

BUG=
==========

to

==========
Tweak the look of the ast and element links in the diagnostics page.

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/44854543eab71adbfeeca4bfd07b42e0d8667623
==========

[devoncarew, 2017-06-12 14:15:45]

Committed patchset #1 (id:1) manually as
44854543eab71adbfeeca4bfd07b42e0d8667623 (presubmit successful).