Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8401)

Unified Diff: chrome/installer/setup/install_worker.cc

Issue 2933043002: Installer support for Windows 10 inactive user toast. (Closed)
Patch Set: now with some tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/install_worker.cc
diff --git a/chrome/installer/setup/install_worker.cc b/chrome/installer/setup/install_worker.cc
index 0eeac1b299b2ae75b8ee2bb6475c468504727849..9ba45b79882453b29460628991b15f568f6580a6 100644
--- a/chrome/installer/setup/install_worker.cc
+++ b/chrome/installer/setup/install_worker.cc
@@ -28,6 +28,7 @@
#include "base/version.h"
#include "base/win/registry.h"
#include "chrome/install_static/install_details.h"
+#include "chrome/install_static/install_modes.h"
#include "chrome/install_static/install_util.h"
#include "chrome/installer/setup/installer_state.h"
#include "chrome/installer/setup/persistent_histogram_storage.h"
@@ -659,6 +660,19 @@ bool AppendPostInstallTasks(const InstallerState& installer_state,
post_install_task_list);
}
+ // Add a best-effort item to create the ClientStateMedium key for system-level
+ // installs. This is ordinarily done by Google Update prior to running
+ // Chrome's installer. Do it here as well so that they key exists for manual
Patrick Monette 2017/06/13 19:13:41 .. so that the key ..
grt (UTC plus 2) 2017/06/14 20:43:44 Done.
+ // installs.
+ if (install_static::kUseGoogleUpdateIntegration &&
+ installer_state.system_install()) {
+ const base::string16 path =
+ install_static::InstallDetails::Get().GetClientStateMediumKeyPath();
+ post_install_task_list
+ ->AddCreateRegKeyWorkItem(HKEY_LOCAL_MACHINE, path, KEY_WOW64_32KEY)
+ ->set_best_effort(true);
+ }
+
return true;
}

Powered by Google App Engine
This is Rietveld 408576698