Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 293303002: history: make checkboxes always visible (instead of just when hovered). (Closed)

Created:
6 years, 7 months ago by Dan Beam
Modified:
6 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

history: fix a11y issue by making checkboxes always visible. this change: - changes border-color instead of opacity of checkboxes on hover - makes checked and hovered checkboxes look more similar - makes hovered rows more noticeable And I touched a few more things that weren't really noticeable before I changed the background color: - checkbox vertical alignment - added padding in front of checkboxes BUG=351565 R=dmazzoni@chromium.org TEST=visible checkboxes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -17 lines) Patch
M chrome/browser/resources/history/history.css View 2 chunks +7 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dan Beam
6 years, 7 months ago (2014-05-23 22:45:36 UTC) #1
dmazzoni
lgtm
6 years, 7 months ago (2014-05-23 23:42:59 UTC) #2
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 7 months ago (2014-05-24 00:04:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/293303002/1
6 years, 7 months ago (2014-05-24 00:05:10 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 13:13:12 UTC) #5
Message was sent while issue was closed.
Change committed as 272735

Powered by Google App Engine
This is Rietveld 408576698