PaymentHandler: PaymentRequestEvent.total should be |object| type.

third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h

Index: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h
index 28e364f6070c22adc7633f85f2f4b445e862275e..6de28a2ee4b41b72056d17967d12a64c6551b635 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h
@@ -5,6 +5,7 @@
 #ifndef PaymentRequestEvent_h
 #define PaymentRequestEvent_h
 
+#include "bindings/core/v8/ScriptValue.h"
 #include "modules/EventModules.h"
 #include "modules/payments/PaymentRequestEventInit.h"
 #include "modules/serviceworkers/ExtendableEvent.h"
@@ -17,15 +18,18 @@ class AtomicString;
 namespace blink {
 
 class RespondWithObserver;
+class ScriptState;
 
 class MODULES_EXPORT PaymentRequestEvent final : public ExtendableEvent {
   DEFINE_WRAPPERTYPEINFO();
   WTF_MAKE_NONCOPYABLE(PaymentRequestEvent);
 
  public:
-  static PaymentRequestEvent* Create(const AtomicString& type,
+  static PaymentRequestEvent* Create(ScriptState*,
+                                     const AtomicString& type,
                                      const PaymentRequestEventInit&);
-  static PaymentRequestEvent* Create(const AtomicString& type,
+  static PaymentRequestEvent* Create(ScriptState*,
+                                     const AtomicString& type,
                                      const PaymentRequestEventInit&,
                                      RespondWithObserver*,
                                      WaitUntilObserver*);
@@ -37,7 +41,7 @@ class MODULES_EXPORT PaymentRequestEvent final : public ExtendableEvent {
   const String& paymentRequestOrigin() const;
   const String& paymentRequestId() const;
   const HeapVector<PaymentMethodData>& methodData() const;
-  void total(PaymentItem& value) const;

[please use gerrit instead, 2017/06/12 14:02:34]

Does keeping the old signature of total() in here work with the new WebIDL?

[zino, 2017/06/12 15:57:18]

The signature is changed by WebIDL compiler because it doesn't return dictionary
type anymore.

+  const ScriptValue& total() const;
   const HeapVector<PaymentDetailsModifier>& modifiers() const;
   const String& instrumentKey() const;
 
@@ -47,7 +51,8 @@ class MODULES_EXPORT PaymentRequestEvent final : public ExtendableEvent {
   DECLARE_VIRTUAL_TRACE();
 
  private:
-  PaymentRequestEvent(const AtomicString& type,
+  PaymentRequestEvent(ScriptState*,
+                      const AtomicString& type,
                       const PaymentRequestEventInit&,
                       RespondWithObserver*,
                       WaitUntilObserver*);
@@ -56,7 +61,7 @@ class MODULES_EXPORT PaymentRequestEvent final : public ExtendableEvent {
   String payment_request_origin_;
   String payment_request_id_;
   HeapVector<PaymentMethodData> method_data_;
-  PaymentItem total_;

[please use gerrit instead, 2017/06/12 14:02:34]

Can we try to keep PaymentItem on stack? I don't think garbage collection works
properly if you keep a ScriptValue as a member variable.

[zino, 2017/06/12 15:57:18]

Done.

+  ScriptValue total_;
   HeapVector<PaymentDetailsModifier> modifiers_;
   String instrument_key_;