Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager

net/http/broken_alternative_services.h

 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_BROKEN_ALTERNATIVE_SERVICES_H_
 #define NET_HTTP_BROKEN_ALTERNATIVE_SERVICES_H_
 
 #include <list>
 #include <unordered_map>
 
 #include "base/memory/weak_ptr.h"
+#include "base/time/default_tick_clock.h"

[Ryan Hamilton, 2017/07/06 16:48:22]

It looks like a fwd-declare of base::TickClock should work, since i don't think
default tick clock is actually used?

[wangyix1, 2017/07/06 18:04:29]

Done.

 #include "base/timer/timer.h"
 #include "net/http/http_server_properties.h"
 
-namespace base {
-class TickClock;
-}
-
 namespace net {
 
 // This class tracks HTTP alternative services that have been marked as broken.
 // The brokenness of an alt-svc will expire after some time according to an
 // exponential back-off formula: each time an alt-svc is marked broken, the
 // expiration delay will be some constant multiple of its previous expiration
 // delay. This prevents broken alt-svcs from being retried too often by the
 // network stack.
 class NET_EXPORT_PRIVATE BrokenAlternativeServices {
  public:
@@ skipping 48 matching lines @@
       const AlternativeService& alternative_service);
 
   // Marks |alternative_service| as not broken and not recently broken.
   void ConfirmAlternativeService(const AlternativeService& alternative_service);
 
   // Sets broken and recently broken alternative services.
   // |broken_alternative_service_list| must be sorted from earliest to latest
   // expiration time.
   // All AlternativeServices in |broken_alternative_service_list| must exist in
   // |recently_broken_alternative_services|.
+  //
+  // If a broken/recently-broken alt svc that's being added is already stored,
+  // the stored expiration/broken-count for that alt svc will be overwritten
+  // with the new value.
   void SetBrokenAndRecentlyBrokenAlternativeServices(
       std::unique_ptr<BrokenAlternativeServiceList>
           broken_alternative_service_list,
       std::unique_ptr<RecentlyBrokenAlternativeServices>
           recently_broken_alternative_services);
 
   const BrokenAlternativeServiceList& broken_alternative_service_list() const;
 
   const RecentlyBrokenAlternativeServices&
   recently_broken_alternative_services() const;
 
  private:
   // TODO (wangyix): modify HttpServerPropertiesImpl unit tests so this
   // friendness is no longer required.
   friend class HttpServerPropertiesImplPeer;
 
-  struct AlternativeServiceHash {
-    size_t operator()(const net::AlternativeService& entry) const {
-      return entry.protocol ^ std::hash<std::string>()(entry.host) ^ entry.port;
-    }
-  };
-
   typedef std::unordered_map<AlternativeService,
                              BrokenAlternativeServiceList::iterator,
                              AlternativeServiceHash>
       BrokenAlternativeServiceMap;
 
   // Inserts |alternative_service| and its |expiration| time into
   // |broken_alternative_service_list_| and |broken_alternative_service_map_|.
   // |it| is the position in |broken_alternative_service_list_| where it was
   // inserted.
   bool AddToBrokenAlternativeServiceListAndMap(
@@ skipping 20 matching lines @@
   // Used for scheduling the task that expires the brokenness of alternative
   // services.
   base::OneShotTimer expiration_timer_;
 
   base::WeakPtrFactory<BrokenAlternativeServices> weak_ptr_factory_;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_BROKEN_ALTERNATIVE_SERVICES_H_