Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager

net/http/http_server_properties.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_server_properties.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "net/socket/ssl_client_socket.h"
 #include "net/ssl/ssl_config.h"
 
 namespace net {
 
 namespace {
 
 enum AlternativeProxyUsage {
   // Alternative Proxy was used without racing a normal connection.
@@ skipping 57 matching lines @@
   }
   NOTREACHED();
   return false;
 }
 
 std::string AlternativeService::ToString() const {
   return base::StringPrintf("%s %s:%d", NextProtoToString(protocol),
                             host.c_str(), port);
 }
 
+bool AlternativeService::FromString(const std::string& str,
+                                    AlternativeService* alternative_service) {
+  size_t space_pos = str.find(' ');
+  if (space_pos == std::string::npos)
+    return false;
+  size_t colon_pos = str.find(':');
+  if (colon_pos == std::string::npos)
+    return false;
+
+  alternative_service->protocol = NextProtoFromString(str.substr(0, space_pos));
+  alternative_service->host =
+      str.substr(space_pos + 1, colon_pos - space_pos - 1);
+
+  unsigned port_uint;
+  if (!base::StringToUint(str.substr(colon_pos + 1), &port_uint))
+    return false;
+  if (port_uint > std::numeric_limits<uint16_t>::max())
+    return false;
+  alternative_service->port = (uint16_t)port_uint;
+
+  return true;
+}

[Ryan Hamilton, 2017/06/12 18:57:32]

Tests?

[wangyix1, 2017/06/14 00:01:25]

Where should the test for this go? There doesn't seem to be any existing tests
that test the AlternativeService class by itself.

+
 std::string AlternativeServiceInfo::ToString() const {
   base::Time::Exploded exploded;
   expiration.LocalExplode(&exploded);
   return base::StringPrintf(
       "%s, expires %04d-%02d-%02d %02d:%02d:%02d",
       alternative_service.ToString().c_str(), exploded.year, exploded.month,
       exploded.day_of_month, exploded.hour, exploded.minute, exploded.second);
 }
 
 std::ostream& operator<<(std::ostream& os,
                          const AlternativeService& alternative_service) {
   os << alternative_service.ToString();
   return os;
 }
 
 // static
 void HttpServerProperties::ForceHTTP11(SSLConfig* ssl_config) {
   ssl_config->alpn_protos.clear();
   ssl_config->alpn_protos.push_back(kProtoHTTP11);
 }
 
 }  // namespace net