Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager

net/http/http_server_properties_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_SERVER_PROPERTIES_IMPL_H_
 #define NET_HTTP_HTTP_SERVER_PROPERTIES_IMPL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <deque>
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/thread_checker.h"
-#include "base/time/default_tick_clock.h"
 #include "base/values.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/ip_address.h"
 #include "net/base/linked_hash_map.h"
 #include "net/base/net_export.h"
 #include "net/http/broken_alternative_services.h"
 #include "net/http/http_server_properties.h"
 
 namespace base {
 class ListValue;
+class TickClock;
 }
 
 namespace net {
 
 // The implementation for setting/retrieving the HTTP server properties.
 class NET_EXPORT HttpServerPropertiesImpl
     : public HttpServerProperties,
       public BrokenAlternativeServices::Delegate {
  public:
+  // |clock| is used for setting expiration times and scheduling the
+  // expiration of broken alternative services. It must not be null.
+  HttpServerPropertiesImpl(base::TickClock* clock);

[Zhongyi Shi, 2017/06/16 04:17:09]

nit: explicit

[wangyix1, 2017/06/16 18:41:15]

Done.

+
+  // Default clock will be used.
   HttpServerPropertiesImpl();
-  explicit HttpServerPropertiesImpl(
-      base::TickClock* broken_alternative_services_clock);
+
   ~HttpServerPropertiesImpl() override;
 
   // Sets |spdy_servers_map_| with the servers (host/port) from
   // |spdy_servers| that either support SPDY or not.
   void SetSpdyServers(std::vector<std::string>* spdy_servers,
                       bool support_spdy);
 
   void SetAlternativeServiceServers(
       AlternativeServiceMap* alternate_protocol_servers);
 
   void SetSupportsQuic(IPAddress* last_address);
 
   void SetServerNetworkStats(ServerNetworkStatsMap* server_network_stats_map);
 
   void SetQuicServerInfoMap(QuicServerInfoMap* quic_server_info_map);
 
   // Get the list of servers (host/port) that support SPDY. The max_size is the
   // number of MRU servers that support SPDY that are to be returned.
   void GetSpdyServerList(base::ListValue* spdy_server_list,
                          size_t max_size) const;
 
+  void SetBrokenAndRecentlyBrokenAlternativeServices(
+      std::unique_ptr<BrokenAlternativeServiceList>
+          broken_alternative_service_list,
+      std::unique_ptr<RecentlyBrokenAlternativeServices>
+          recently_broken_alternative_services);

[Zhongyi Shi, 2017/06/16 04:17:09]

Does the raw pointers work? Usually pass by unique_ptr means ownership transfer.
I didn't quite get why the ownership of the broken_alternative_service_list need
to be transferred. 

[wangyix1, 2017/06/16 18:41:15]

unique_ptrs are used since these params are simply passed through to
BrokenAlternativeServices::SetBrokenAndRecentlyBrokenAlternativeServices().
I chose to use unique_ptr params for
BrokenAlternativeServices::SetBrokenAndRecentlyBrokenAlternativeServices()
because its implementation modifies |broken_alternative_service_list| and
|recently_broken_alternative_services|. I suppose I could use raw pointers, but
I think using unique_ptrs makes it clear that those objects should not be used
after calling this function. Thoughts?

+
+  const BrokenAlternativeServiceList& broken_alternative_service_list() const;
+
+  const RecentlyBrokenAlternativeServices&
+  recently_broken_alternative_services() const;
+
   // Returns flattened string representation of the |host_port_pair|. Used by
   // unittests.
   static std::string GetFlattenedSpdyServer(const HostPortPair& host_port_pair);
 
   // Returns the canonical host suffix for |host|, or nullptr if none
   // exists.
   const std::string* GetCanonicalSuffix(const std::string& host) const;
 
   // -----------------------------
   // HttpServerProperties methods:
@@ skipping 66 matching lines @@
   AlternativeServiceMap::const_iterator GetAlternateProtocolIterator(
       const url::SchemeHostPort& server);
 
   // Return the canonical host for |server|, or end if none exists.
   CanonicalHostMap::const_iterator GetCanonicalHost(
       const url::SchemeHostPort& server) const;
 
   // Remove the cononical host for |server|.
   void RemoveCanonicalHost(const url::SchemeHostPort& server);
 
-  base::DefaultTickClock broken_alternative_services_clock_;
-  BrokenAlternativeServices broken_alternative_services_;
+  base::DefaultTickClock default_clock_;
 
   SpdyServersMap spdy_servers_map_;
   Http11ServerHostPortSet http11_servers_;
 
   AlternativeServiceMap alternative_service_map_;
 
+  BrokenAlternativeServices broken_alternative_services_;
+
   IPAddress last_quic_address_;
   ServerNetworkStatsMap server_network_stats_map_;
   // Contains a map of servers which could share the same alternate protocol.
   // Map from a Canonical scheme/host/port (host is some postfix of host names)
   // to an actual origin, which has a plausible alternate protocol mapping.
   CanonicalHostMap canonical_host_to_origin_map_;
   // Contains list of suffixes (for exmaple ".c.youtube.com",
   // ".googlevideo.com", ".googleusercontent.com") of canonical hostnames.
   CanonicalSufficList canonical_suffixes_;
 
   QuicServerInfoMap quic_server_info_map_;
   size_t max_server_configs_stored_in_properties_;
 
   THREAD_CHECKER(thread_checker_);
 
   DISALLOW_COPY_AND_ASSIGN(HttpServerPropertiesImpl);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_SERVER_PROPERTIES_IMPL_H_