Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc

Issue 2932893002: BrowserMainLoop owns FrameSinkManagerHost (Closed)
Patch Set: Fix offscreen canvas unit tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc
diff --git a/content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc b/content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc
index 6d2b10787ca64cf8dd98ba1c853ff6ad5c67822f..c6c5ef49f62a6097e3332f4cedef1c34972306a2 100644
--- a/content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc
+++ b/content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc
@@ -147,13 +147,11 @@ class OffscreenCanvasProviderImplTest : public testing::Test {
ImageTransportFactory::InitializeForUnitTests(
std::unique_ptr<ImageTransportFactory>(
new NoTransportImageTransportFactory));
- ImageTransportFactory::GetInstance()
- ->GetContextFactoryPrivate()
- ->GetFrameSinkManagerHost()
- ->ConnectToFrameSinkManager();
#endif
- provider_ =
- base::MakeUnique<OffscreenCanvasProviderImpl>(kRendererClientId);
+ frame_sink_manager_host_ = base::MakeUnique<viz::FrameSinkManagerHost>();
danakj 2017/06/09 22:43:37 Please destroy things in TearDown that are created
Fady Samuel 2017/06/09 22:52:39 Done.
+ frame_sink_manager_host_->ConnectToFrameSinkManager();
+ provider_ = base::MakeUnique<OffscreenCanvasProviderImpl>(
+ frame_sink_manager_host_.get(), kRendererClientId);
}
void TearDown() override {
provider_.reset();
@@ -164,6 +162,7 @@ class OffscreenCanvasProviderImplTest : public testing::Test {
private:
base::MessageLoop message_loop_;
+ std::unique_ptr<viz::FrameSinkManagerHost> frame_sink_manager_host_;
std::unique_ptr<OffscreenCanvasProviderImpl> provider_;
};

Powered by Google App Engine
This is Rietveld 408576698