Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2932883002: Add FrontendStrategy.commonElements and remove Backend.commonElements (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, Emily Fortuna
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add FrontendStrategy.commonElements and remove Backend.commonElements This a step towards support different models between the frontend and the backend. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/bed356cd463ccd99d8adf9092d463662079ea69d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -83 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/frontend_strategy.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/list_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/map_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 22 chunks +37 lines, -49 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/element_strategy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 2 chunks +11 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 4 chunks +16 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 5 chunks +7 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
3 years, 6 months ago (2017-06-09 19:25:34 UTC) #2
Emily Fortuna
lgtm
3 years, 6 months ago (2017-06-09 19:58:54 UTC) #4
Johnni Winther
3 years, 6 months ago (2017-06-12 07:35:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
bed356cd463ccd99d8adf9092d463662079ea69d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698