move ashmem switching logic to SkDiscardableMemory::Create

move ashmem switching logic to SkDiscardableMemory::Create

Committed: http://code.google.com/p/skia/source/detail?r=14882

[hal.canary, 2014-05-23 19:46:47]

ptal

[scroggo, 2014-05-23 19:54:03]

https://codereview.chromium.org/293283002/diff/1/src/ports/SkDiscardableMemor...
File src/ports/SkDiscardableMemory_ashmem.cpp (right):

https://codereview.chromium.org/293283002/diff/1/src/ports/SkDiscardableMemor...
src/ports/SkDiscardableMemory_ashmem.cpp:118: #ifndef
SKIA_ASHMEM_MINIMUM_MEMORY_SIZE
I think this should be SK_ASHMEM_MINIMUM_MEMORY_SIZE

(i.e. SK instead of SKIA).

https://codereview.chromium.org/293283002/diff/1/src/ports/SkDiscardableMemor...
src/ports/SkDiscardableMemory_ashmem.cpp:119: #define
SKIA_ASHMEM_MINIMUM_MEMORY_SIZE (3 * 1024)
Android defines this to 32 * 1024, correct? Did you deliberately choose
something different?

If you did, could you add a define to gyp/common_conditions.gypi under
skia_android_framework's defines?

https://codereview.chromium.org/293283002/diff/1/src/ports/SkDiscardableMemor...
src/ports/SkDiscardableMemory_ashmem.cpp:125: return
SkAshmemDiscardableMemory::Create(size_t bytes);
no need for 'size_t' here.

[hal.canary, 2014-05-23 20:09:22]

https://codereview.chromium.org/293283002/diff/1/src/ports/SkDiscardableMemor...
File src/ports/SkDiscardableMemory_ashmem.cpp (right):

https://codereview.chromium.org/293283002/diff/1/src/ports/SkDiscardableMemor...
src/ports/SkDiscardableMemory_ashmem.cpp:118: #ifndef
SKIA_ASHMEM_MINIMUM_MEMORY_SIZE
On 2014/05/23 19:54:03, scroggo wrote:
> I think this should be SK_ASHMEM_MINIMUM_MEMORY_SIZE
> 
> (i.e. SK instead of SKIA).

Done.

https://codereview.chromium.org/293283002/diff/1/src/ports/SkDiscardableMemor...
src/ports/SkDiscardableMemory_ashmem.cpp:119: #define
SKIA_ASHMEM_MINIMUM_MEMORY_SIZE (3 * 1024)
On 2014/05/23 19:54:03, scroggo wrote:
> Android defines this to 32 * 1024, correct? Did you deliberately choose
> something different?
> 
> If you did, could you add a define to gyp/common_conditions.gypi under
> skia_android_framework's defines?

I miscopied that.  fixed.

https://codereview.chromium.org/293283002/diff/1/src/ports/SkDiscardableMemor...
src/ports/SkDiscardableMemory_ashmem.cpp:125: return
SkAshmemDiscardableMemory::Create(size_t bytes);
On 2014/05/23 19:54:03, scroggo wrote:
> no need for 'size_t' here.

I would have caught that when I tried to compile on android.

Done.

[scroggo, 2014-05-23 20:17:58]

lgtm

[hal.canary, 2014-05-23 20:19:13]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-05-23 20:19:43]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/halcanary@google.com/293283002/20001

[commit-bot: I haz the power, 2014-05-23 20:25:17]

Change committed as 14882