Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2932793005: Rename FrontEndStrategy to FrontendStrategy (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename FrontEndStrategy to FrontendStrategy It hurts my eyes to see FrontEndStrategy frontEndStrategy ... BackendStrategy backendStrategy ... R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/61c100da491bd29fe2192b773af96f2b72abe845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/frontend_strategy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 8 chunks +12 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/tool/perf.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_from_dill_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/compiler_helper.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Johnni Winther
3 years, 6 months ago (2017-06-09 16:52:17 UTC) #2
Emily Fortuna
lgtm https://www.youtube.com/watch?v=ta_myupIJm0
3 years, 6 months ago (2017-06-09 19:53:38 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as 61c100da491bd29fe2192b773af96f2b72abe845 (presubmit successful).
3 years, 6 months ago (2017-06-12 07:30:26 UTC) #5
Siggi Cherem (dart-lang)
3 years, 6 months ago (2017-06-14 21:58:35 UTC) #7
Message was sent while issue was closed.
ha! We went in the opposite direction in package:front_end (it is why we called
it front_end and not frontend).

I honestly don't mind though :)

Powered by Google App Engine
This is Rietveld 408576698