Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2932723003: Complain about incorrect use of null-aware operations. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -22 lines) Patch
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 3 chunks +16 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/language_kernel.status View 2 chunks +0 lines, -22 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
ahe
3 years, 6 months ago (2017-06-09 11:34:47 UTC) #2
Johnni Winther
lgtm
3 years, 6 months ago (2017-06-09 11:56:38 UTC) #3
danrubel
LGTM
3 years, 6 months ago (2017-06-09 17:16:06 UTC) #4
ahe
3 years, 6 months ago (2017-06-10 08:11:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dcbac2be009afff66bf6a11b7df89d2b68bedca0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698