chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h - Issue 2932703006: Chrome Cleaner: Remove indirect base::FilePath mojo dependency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h

Issue 2932703006: Chrome Cleaner: Remove indirect base::FilePath mojo dependency. (Closed)

Patch Set: Address review comments, make tests pass Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_process_win.cc ('K') | « chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_process_win.cc ('k') | chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.cc » ('j') | chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h

diff --git a/chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h b/chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h

index c3d26c7a41494047b6a9e05de1c83f85a0d9c964..9de76e83f59b6e3e6aa087c34d2939ea28c6e1d2 100644

--- a/chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h

+++ b/chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h

@@ -30,9 +30,10 @@ class ChromePromptImpl : public chrome_cleaner::mojom::ChromePrompt {

OnPromptUser on_prompt_user);

~ChromePromptImpl() override;

- void PromptUser(const std::vector<base::FilePath>& files_to_delete,

- chrome_cleaner::mojom::ChromePrompt::PromptUserCallback

- callback) override;

+ void PromptUser(

+ std::vector<chrome_cleaner::mojom::FilePathPtr> files_to_delete,

+ chrome_cleaner::mojom::ChromePrompt::PromptUserCallback callback)

+ override;

private:

mojo::Binding<chrome_cleaner::mojom::ChromePrompt> binding_;