Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: components/chrome_cleaner/public/interfaces/chrome_prompt.mojom

Issue 2932703006: Chrome Cleaner: Remove indirect base::FilePath mojo dependency. (Closed)
Patch Set: Address review comments on #5 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/chrome_cleaner/public/typemaps/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/chrome_cleaner/public/interfaces/chrome_prompt.mojom
diff --git a/components/chrome_cleaner/public/interfaces/chrome_prompt.mojom b/components/chrome_cleaner/public/interfaces/chrome_prompt.mojom
index 07013fe06431897c6d0486f5d135eb8c1df37b3d..e935de9d570882ed42d6c9f35c91afd2d3a1c904 100644
--- a/components/chrome_cleaner/public/interfaces/chrome_prompt.mojom
+++ b/components/chrome_cleaner/public/interfaces/chrome_prompt.mojom
@@ -4,7 +4,14 @@
module chrome_cleaner.mojom;
-import "mojo/common/file_path.mojom";
+// IMPORTANT NOTE: Avoid adding dependencies to typemapped .mojom files.
+// Enabling typemaps currently (as of July 2017) requires indirectly depending
+// on all existing typemap definitions. The Chrome Cleaner is built
+// independently from Chromium and would like to avoid these dependencies.
+
+// Once it's possible to specify a limited subset of typemaps to use, be
+// careful not to add dependencies to [Native] mojo structures. The wire format
+// for [Native] structs is not guaranteed to be consistent between versions.
[Extensible]
enum PromptAcceptance {
@@ -21,6 +28,10 @@ enum PromptAcceptance {
IGNORED = 4,
};
+struct FilePath {
+ array<uint16> value;
+};
+
// Service provided by Chrome to prompt the user to start a cleanup if the
// Chrome Cleanup Tool detects unwanted software on the system.
interface ChromePrompt {
@@ -29,6 +40,6 @@ interface ChromePrompt {
// will be deleted by the Chrome Cleanup Tool.
// Returns:
// - prompt_acceptance: indicates if the user accepted the prompt.
- PromptUser(array<mojo.common.mojom.FilePath> files_to_delete)
+ PromptUser(array<FilePath> files_to_delete)
=> (PromptAcceptance prompt_acceptance);
};
« no previous file with comments | « no previous file | components/chrome_cleaner/public/typemaps/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698