Chrome Cleaner: Remove indirect base::FilePath mojo dependency.

chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h"
 
 #include <utility>
 
 #include "base/files/file_path.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "content/public/browser/browser_thread.h"
 
 namespace safe_browsing {
 
+namespace {
+
+base::FilePath CastUInt16ToFilePath(const uint16_t* string) {
+  return base::FilePath(reinterpret_cast<const wchar_t*>(string));
+}
+
+}  // namespace
+
 using chrome_cleaner::mojom::ChromePrompt;
 using chrome_cleaner::mojom::ChromePromptRequest;
 using chrome_cleaner::mojom::PromptAcceptance;
 using content::BrowserThread;
 
 ChromePromptImpl::ChromePromptImpl(ChromePromptRequest request,
                                    base::Closure on_connection_closed,
                                    OnPromptUser on_prompt_user)
     : binding_(this, std::move(request)),
       on_prompt_user_(std::move(on_prompt_user)) {
   DCHECK(on_prompt_user_);
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   binding_.set_connection_error_handler(std::move(on_connection_closed));
 }
 
 ChromePromptImpl::~ChromePromptImpl() {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
 }
 
 void ChromePromptImpl::PromptUser(
-    const std::vector<base::FilePath>& files_to_delete,
+    std::vector<chrome_cleaner::mojom::FilePathPtr> files_to_delete,
     ChromePrompt::PromptUserCallback callback) {
+  std::vector<base::FilePath> file_paths;

[Fabio Tirelo, 2017/06/12 14:04:50]

Instead of creating this vector to later copy all elements to a set, why not
using a set directly here?

[proberge, 2017/06/12 17:49:30]

Done.

+  for (const chrome_cleaner::mojom::FilePathPtr& file_path_ptr :
+       files_to_delete) {

[Fabio Tirelo, 2017/06/12 14:04:50]

Please move this to inside the conditional in line 54.

[proberge, 2017/06/12 17:49:30]

Done.

+    file_paths.push_back(
+        CastUInt16ToFilePath(file_path_ptr.get()->value.data()));
+  }
+
   if (on_prompt_user_) {
     std::move(on_prompt_user_)
-        .Run(base::MakeUnique<std::set<base::FilePath>>(files_to_delete.begin(),
-                                                        files_to_delete.end()),
+        .Run(base::MakeUnique<std::set<base::FilePath>>(file_paths.begin(),
+                                                        file_paths.end()),
              std::move(callback));
   }
 }
 
 }  // namespace safe_browsing