Plumbing for safe browsing reporting for Android WebView.

android_webview/browser/aw_safe_browsing_ui_manager.h

Index: android_webview/browser/aw_safe_browsing_ui_manager.h
diff --git a/android_webview/browser/aw_safe_browsing_ui_manager.h b/android_webview/browser/aw_safe_browsing_ui_manager.h
index 79873c600ac10dc8b23ad22deac5bff6063e0b99..d4dab6ab05ddfbb95f2f18e7780c89ff0ca5b1be 100644
--- a/android_webview/browser/aw_safe_browsing_ui_manager.h
+++ b/android_webview/browser/aw_safe_browsing_ui_manager.h
@@ -12,7 +12,13 @@
 #include "components/safe_browsing/base_ui_manager.h"
 #include "content/public/browser/web_contents.h"
 
+namespace safe_browsing {
+class BasePingManager;
+class SafeBrowsingURLRequestContextGetter;
+}  // namespace
+
 namespace android_webview {
+class AwURLRequestContextGetter;
 
 class AwSafeBrowsingUIManager : public safe_browsing::BaseUIManager {
  public:
@@ -28,19 +34,33 @@ class AwSafeBrowsingUIManager : public safe_browsing::BaseUIManager {
   };
 
   // Construction needs to happen on the UI thread.
-  AwSafeBrowsingUIManager();
+  explicit AwSafeBrowsingUIManager(
+      AwURLRequestContextGetter* browser_url_request_context_getter);
 
   void DisplayBlockingPage(const UnsafeResource& resource) override;
 
   // Gets the correct ErrorUiType for the web contents
   int GetErrorUiType(const UnsafeResource& resource) const;
 
+  // BaseUIManager:

[Nate Fischer, 2017/06/08 22:21:47]

Any reason why we're mentioning the base class here?

[timvolodine, 2017/06/09 11:52:10]

This is sort of standard practice to indicate the methods below are overridden
from the BaseUIManager class (we have similar comment e.g. in base_blocking_page
and base_ping_manager). I've modified the comment to "BaseUIManager methods:" to
make it clearer and also moved the DisplayBlockingPage() method in this section.

+  // Called on the IO thread by the ThreatDetails with the serialized
+  // protocol buffer, so the service can send it over.
+  void SendSerializedThreatDetails(const std::string& serialized) override;
+
  protected:
   ~AwSafeBrowsingUIManager() override;
 
   void ShowBlockingPageForResource(const UnsafeResource& resource) override;
 
  private:
+  // Provides phishing and malware statistics. Accessed on IO thread.
+  std::unique_ptr<safe_browsing::BasePingManager> ping_manager_;
+
+  // The SafeBrowsingURLRequestContextGetter used to access
+  // |url_request_context_|. Accessed on UI thread.
+  scoped_refptr<safe_browsing::SafeBrowsingURLRequestContextGetter>
+      url_request_context_getter_;
+
   DISALLOW_COPY_AND_ASSIGN(AwSafeBrowsingUIManager);
 };