extensions/browser/guest_view/web_view/BUILD.gn - Issue 2932643004: Extensions: Move targets in extensions/browser/guest_view to extensions/browser:browser_sources.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/guest_view/web_view/BUILD.gn

Issue 2932643004: Extensions: Move targets in extensions/browser/guest_view to extensions/browser:browser_sources. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « extensions/browser/guest_view/mime_handler_view/BUILD.gn ('k') | extensions/browser/guest_view/web_view/web_ui/BUILD.gn » ('j') | extensions/browser/guest_view/web_view/web_ui/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.

4

5 source_set("web_view") {
Devlin 2017/06/12 15:20:20 This one's a bit disappointing. Conceptually, I d This one's a bit disappointing. Conceptually, I don't think webview should depend on the extensions system (whereas other implementations, like extension_options, clearly should). I wonder if we can add a TODO to that effect in the monolithic build file? karandeepb 2017/06/12 21:10:49 Have added a TODO to that effect. Show quoted text On 2017/06/12 15:20:20, Devlin (sheriff Jun 9 - 12) wrote: > This one's a bit disappointing. Conceptually, I don't think webview should > depend on the extensions system (whereas other implementations, like > extension_options, clearly should). I wonder if we can add a TODO to that > effect in the monolithic build file? Have added a TODO to that effect.
6 sources = [

7 "javascript_dialog_helper.cc",

8 "javascript_dialog_helper.h",

9 "web_view_constants.cc",

10 "web_view_constants.h",

11 "web_view_content_script_manager.cc",

12 "web_view_content_script_manager.h",

13 "web_view_find_helper.cc",

14 "web_view_find_helper.h",

15 "web_view_guest.cc",

16 "web_view_guest.h",

17 "web_view_guest_delegate.h",

18 "web_view_permission_helper.cc",

19 "web_view_permission_helper.h",

20 "web_view_permission_helper_delegate.cc",

21 "web_view_permission_helper_delegate.h",

22 "web_view_permission_types.h",

23 "web_view_renderer_state.cc",

24 "web_view_renderer_state.h",

25 ]

26

27 deps = [

28 "//components/web_cache/browser",

29 "//content/public/common",

30 "//extensions/common/api",

31 "//extensions/strings",

32 "//ppapi/features",

33 ]

34 }

OLD	NEW