Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4863)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 2932613002: Fix race causing crash in net::FileNetLogObserver shutdown (Closed)
Patch Set: add tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/log/file_net_log_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
index f2d0c0188aede7285884419c5a43c0de031725cb..186cff6b19f77ff0e99132e7dcc2aa0a5e96480d 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
@@ -19,7 +19,6 @@ import static org.chromium.net.CronetEngine.Builder.HTTP_CACHE_IN_MEMORY;
import org.chromium.base.FileUtils;
import org.chromium.base.PathUtils;
import org.chromium.base.annotations.JNINamespace;
-import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.net.TestUrlRequestCallback.ResponseStep;
import org.chromium.net.impl.CronetEngineBuilderImpl;
@@ -487,11 +486,9 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
assertTrue(file2.delete());
}
- //@SmallTest
- //@Feature({"Cronet"})
- //@OnlyRunNativeCronet
- // Frequently crashes on Cronet builders - see crbug.com/729257
- @DisabledTest
+ @SmallTest
+ @Feature({"Cronet"})
+ @OnlyRunNativeCronet
// Tests that NetLog contains events emitted by all live CronetEngines.
public void testBoundedFileNetLogContainEventsFromAllLiveEngines() throws Exception {
Context context = getContext();
« no previous file with comments | « no previous file | net/log/file_net_log_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698