Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 2932593004: Update the snap points css properties (Closed)
Patch Set: Fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/UseCounter.cpp
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.cpp b/third_party/WebKit/Source/core/frame/UseCounter.cpp
index e803c8551ac4a10291fa4940c9d952cafb08b875..f801238628e79baa50f2037e13bec295e3179936 100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.cpp
+++ b/third_party/WebKit/Source/core/frame/UseCounter.cpp
@@ -46,7 +46,7 @@ int totalPagesMeasuredCSSSampleId() {
}
// Make sure update_use_counter_css.py was run which updates histograms.xml.
-constexpr int kMaximumCSSSampleId = 560;
+constexpr int kMaximumCSSSampleId = 584;
} // namespace
@@ -963,14 +963,10 @@ int UseCounter::MapCSSPropertyIdToCSSSampleIdForHistogram(
return 498;
case CSSPropertyScrollSnapType:
return 499;
- case CSSPropertyScrollSnapPointsX:
- return 500;
- case CSSPropertyScrollSnapPointsY:
- return 501;
- case CSSPropertyScrollSnapCoordinate:
- return 502;
- case CSSPropertyScrollSnapDestination:
- return 503;
+ // CSSPropertyScrollSnapPointsX was 500.
+ // CSSPropertyScrollSnapPointsY was 501.
+ // CSSPropertyScrollSnapCoordinate was 502.
+ // CSSPropertyScrollSnapDestination was 503.
case CSSPropertyTranslate:
return 504;
case CSSPropertyRotate:
@@ -1084,6 +1080,54 @@ int UseCounter::MapCSSPropertyIdToCSSSampleIdForHistogram(
return 559;
case CSSPropertyPlaceSelf:
return 560;
+ case CSSPropertyScrollSnapAlign:
+ return 561;
+ case CSSPropertyScrollPadding:
+ return 562;
+ case CSSPropertyScrollPaddingTop:
+ return 563;
+ case CSSPropertyScrollPaddingRight:
+ return 564;
+ case CSSPropertyScrollPaddingBottom:
+ return 565;
+ case CSSPropertyScrollPaddingLeft:
+ return 566;
+ case CSSPropertyScrollPaddingBlock:
+ return 567;
+ case CSSPropertyScrollPaddingBlockStart:
+ return 568;
+ case CSSPropertyScrollPaddingBlockEnd:
+ return 569;
+ case CSSPropertyScrollPaddingInline:
+ return 570;
+ case CSSPropertyScrollPaddingInlineStart:
+ return 571;
+ case CSSPropertyScrollPaddingInlineEnd:
+ return 572;
+ case CSSPropertyScrollSnapMargin:
+ return 573;
+ case CSSPropertyScrollSnapMarginTop:
+ return 574;
+ case CSSPropertyScrollSnapMarginRight:
+ return 575;
+ case CSSPropertyScrollSnapMarginBottom:
+ return 576;
+ case CSSPropertyScrollSnapMarginLeft:
+ return 577;
+ case CSSPropertyScrollSnapMarginBlock:
+ return 578;
+ case CSSPropertyScrollSnapMarginBlockStart:
+ return 579;
+ case CSSPropertyScrollSnapMarginBlockEnd:
+ return 580;
+ case CSSPropertyScrollSnapMarginInline:
+ return 581;
+ case CSSPropertyScrollSnapMarginInlineStart:
+ return 582;
+ case CSSPropertyScrollSnapMarginInlineEnd:
+ return 583;
+ case CSSPropertyScrollSnapStop:
+ return 584;
// 1. Add new features above this line (don't change the assigned numbers of
// the existing items).
// 2. Update kMaximumCSSSampleId with the new maximum value.

Powered by Google App Engine
This is Rietveld 408576698