Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/css/CSSProperties.json5

Issue 2932593004: Update the snap points css properties (Closed)
Patch Set: update some tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('K') | « third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('k') | third_party/WebKit/Source/core/css/CSSProperty.cpp » ('j') | third_party/WebKit/Source/core/css/CSSValueKeywords.json5 » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSProperties.json5
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.json5 b/third_party/WebKit/Source/core/css/CSSProperties.json5
index b4b7ce07e3d425bf25ca55e84fbcae4dac2783d2..ac8212ad600edc27059d025e354242060ca6ca86 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.json5
+++ b/third_party/WebKit/Source/core/css/CSSProperties.json5
@@ -1849,29 +1849,201 @@
},
{
name: "scroll-snap-type",
+ api_class: true,
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertSnapType",
+ getter: "GetScrollSnapType",
runtime_flag: "CSSScrollSnapPoints",
- type_name: "ScrollSnapType",
},
{
- name: "scroll-snap-points-x",
- converter: "ConvertSnapPoints",
+ name: "scroll-snap-align",
+ api_class: true,
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertSnapAlign",
+ getter: "GetScrollSnapAlign",
runtime_flag: "CSSScrollSnapPoints",
},
{
- name: "scroll-snap-points-y",
- converter: "ConvertSnapPoints",
+ name: "scroll-snap-stop",
+ default_value: "normal",
+ field_template: "keyword",
shend 2017/06/14 01:37:38 When you add this line, I believe that the enum ma
sunyunjia 2017/06/14 18:36:21 Acknowledged.
+ keywords: ["normal", "always"],
runtime_flag: "CSSScrollSnapPoints",
},
{
- name: "scroll-snap-destination",
- converter: "ConvertPosition",
+ name: "scroll-padding-top",
+ api_class: "CSSPropertyAPIScrollPadding",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollPadding",
+ include_paths: ["platform/Length.h"],
+ typedom_types: ["Length", "Percent"],
+ type_name: "Length",
runtime_flag: "CSSScrollSnapPoints",
},
{
- name: "scroll-snap-coordinate",
- api_class: true,
+ name: "scroll-padding-bottom",
+ api_class: "CSSPropertyAPIScrollPadding",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollPadding",
+ include_paths: ["platform/Length.h"],
+ typedom_types: ["Length", "Percent"],
+ type_name: "Length",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-padding-left",
+ api_class: "CSSPropertyAPIScrollPadding",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollPadding",
+ include_paths: ["platform/Length.h"],
+ typedom_types: ["Length", "Percent"],
+ type_name: "Length",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-padding-right",
+ api_class: "CSSPropertyAPIScrollPadding",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollPadding",
+ include_paths: ["platform/Length.h"],
+ typedom_types: ["Length", "Percent"],
+ type_name: "Length",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-padding-block-start",
+ api_class: "CSSPropertyAPIScrollPadding",
api_methods: ["parseSingleValue"],
- converter: "ConvertSnapCoordinates",
+ converter: "ConvertLength",
+ initial: "InitialScrollPadding",
+ include_paths: ["platform/Length.h"],
+ typedom_types: ["Length", "Percent"],
+ type_name: "Length",
+ direction_aware: true,
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-padding-block-end",
+ api_class: "CSSPropertyAPIScrollPadding",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollPadding",
+ include_paths: ["platform/Length.h"],
+ typedom_types: ["Length", "Percent"],
+ type_name: "Length",
+ direction_aware: true,
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-padding-inline-start",
+ api_class: "CSSPropertyAPIScrollPadding",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollPadding",
+ include_paths: ["platform/Length.h"],
+ typedom_types: ["Length", "Percent"],
+ type_name: "Length",
+ direction_aware: true,
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-padding-inline-end",
+ api_class: "CSSPropertyAPIScrollPadding",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollPadding",
+ include_paths: ["platform/Length.h"],
+ typedom_types: ["Length", "Percent"],
+ type_name: "Length",
+ direction_aware: true,
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-snap-margin-top",
+ api_class: "CSSPropertyAPIScrollSnapMargin",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollSnapMargin",
+ include_paths: ["platform/Length.h"],
+ type_name: "Length",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-snap-margin-bottom",
+ api_class: "CSSPropertyAPIScrollSnapMargin",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollSnapMargin",
+ include_paths: ["platform/Length.h"],
+ type_name: "Length",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-snap-margin-left",
+ api_class: "CSSPropertyAPIScrollSnapMargin",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollSnapMargin",
+ include_paths: ["platform/Length.h"],
+ type_name: "Length",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-snap-margin-right",
+ api_class: "CSSPropertyAPIScrollSnapMargin",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollSnapMargin",
+ include_paths: ["platform/Length.h"],
+ type_name: "Length",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-snap-margin-block-start",
+ api_class: "CSSPropertyAPIScrollSnapMargin",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollSnapMargin",
+ direction_aware: true,
+ include_paths: ["platform/Length.h"],
+ type_name: "Length",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-snap-margin-block-end",
+ api_class: "CSSPropertyAPIScrollSnapMargin",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollSnapMargin",
+ direction_aware: true,
+ include_paths: ["platform/Length.h"],
+ type_name: "Length",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-snap-margin-inline-start",
+ api_class: "CSSPropertyAPIScrollSnapMargin",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollSnapMargin",
+ direction_aware: true,
+ include_paths: ["platform/Length.h"],
+ type_name: "Length",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-snap-margin-inline-end",
+ api_class: "CSSPropertyAPIScrollSnapMargin",
+ api_methods: ["parseSingleValue"],
+ converter: "ConvertLength",
+ initial: "InitialScrollSnapMargin",
+ direction_aware: true,
+ include_paths: ["platform/Length.h"],
+ type_name: "Length",
runtime_flag: "CSSScrollSnapPoints",
},
{
@@ -3212,6 +3384,36 @@
name: "page-break-inside",
longhands: "break-inside",
},
+ {
+ name: "scroll-padding",
+ longhands: "scroll-padding-top;scroll-padding-right;scroll-padding-bottom;scroll-padding-left",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-padding-block",
+ longhands: "scroll-padding-block-start;scroll-padding-block-end",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-padding-inline",
+ longhands: "scroll-padding-inline-start;scroll-padding-inline-end",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-snap-margin",
+ longhands: "scroll-snap-margin-top;scroll-snap-margin-right;scroll-snap-margin-bottom;scroll-snap-margin-left",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-snap-margin-block",
+ longhands: "scroll-snap-margin-block-start;scroll-snap-margin-block-end",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
+ {
+ name: "scroll-snap-margin-inline",
+ longhands: "scroll-snap-margin-inline-start;scroll-snap-margin-inline-end",
+ runtime_flag: "CSSScrollSnapPoints",
+ },
{
name: "transition",
longhands: "transition-property;transition-duration;transition-timing-function;transition-delay",
« third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('K') | « third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('k') | third_party/WebKit/Source/core/css/CSSProperty.cpp » ('j') | third_party/WebKit/Source/core/css/CSSValueKeywords.json5 » ('J')

Powered by Google App Engine
This is Rietveld 408576698