Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 2932593004: Update the snap points css properties (Closed)
Patch Set: Add CSS Attributes Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Zack Rusin <zack@kde.org> 2 * Copyright (C) 2004 Zack Rusin <zack@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc.
4 * All rights reserved. 4 * All rights reserved.
5 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 5 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
6 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 6 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
7 * Copyright (C) 2011 Sencha, Inc. All rights reserved. 7 * Copyright (C) 2011 Sencha, Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Lesser General Public 10 * modify it under the terms of the GNU Lesser General Public
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 CSSPropertyFillRule, CSSPropertyMarkerEnd, CSSPropertyMarkerMid, 166 CSSPropertyFillRule, CSSPropertyMarkerEnd, CSSPropertyMarkerMid,
167 CSSPropertyMarkerStart, CSSPropertyMaskType, CSSPropertyMaskSourceType, 167 CSSPropertyMarkerStart, CSSPropertyMaskType, CSSPropertyMaskSourceType,
168 CSSPropertyShapeRendering, CSSPropertyStroke, CSSPropertyStrokeDasharray, 168 CSSPropertyShapeRendering, CSSPropertyStroke, CSSPropertyStrokeDasharray,
169 CSSPropertyStrokeDashoffset, CSSPropertyStrokeLinecap, 169 CSSPropertyStrokeDashoffset, CSSPropertyStrokeLinecap,
170 CSSPropertyStrokeLinejoin, CSSPropertyStrokeMiterlimit, 170 CSSPropertyStrokeLinejoin, CSSPropertyStrokeMiterlimit,
171 CSSPropertyStrokeOpacity, CSSPropertyStrokeWidth, 171 CSSPropertyStrokeOpacity, CSSPropertyStrokeWidth,
172 CSSPropertyAlignmentBaseline, CSSPropertyBaselineShift, 172 CSSPropertyAlignmentBaseline, CSSPropertyBaselineShift,
173 CSSPropertyDominantBaseline, CSSPropertyTextAnchor, CSSPropertyWritingMode, 173 CSSPropertyDominantBaseline, CSSPropertyTextAnchor, CSSPropertyWritingMode,
174 CSSPropertyVectorEffect, CSSPropertyPaintOrder, CSSPropertyD, CSSPropertyCx, 174 CSSPropertyVectorEffect, CSSPropertyPaintOrder, CSSPropertyD, CSSPropertyCx,
175 CSSPropertyCy, CSSPropertyX, CSSPropertyY, CSSPropertyR, CSSPropertyRx, 175 CSSPropertyCy, CSSPropertyX, CSSPropertyY, CSSPropertyR, CSSPropertyRx,
176 CSSPropertyRy, CSSPropertyScrollSnapType, CSSPropertyScrollSnapPointsX, 176 CSSPropertyRy, CSSPropertyTranslate, CSSPropertyRotate, CSSPropertyScale,
177 CSSPropertyScrollSnapPointsY, CSSPropertyScrollSnapCoordinate, 177 CSSPropertyCaretColor, CSSPropertyScrollSnapType,
bokan 2017/06/13 01:30:20 The comment above says we shouldn't use this for f
sunyunjia 2017/06/13 17:44:59 Done.
178 CSSPropertyScrollSnapDestination, CSSPropertyTranslate, CSSPropertyRotate, 178 CSSPropertyScrollSnapAlign, CSSPropertyScrollPadding,
179 CSSPropertyScale, CSSPropertyCaretColor}; 179 CSSPropertyScrollPaddingTop, CSSPropertyScrollPaddingRight,
180 CSSPropertyScrollPaddingBottom, CSSPropertyScrollPaddingLeft,
181 CSSPropertyScrollPaddingBlock, CSSPropertyScrollPaddingBlockStart,
182 CSSPropertyScrollPaddingBlockEnd, CSSPropertyScrollPaddingInline,
183 CSSPropertyScrollPaddingInlineStart, CSSPropertyScrollPaddingInlineEnd,
184 CSSPropertyScrollSnapMargin, CSSPropertyScrollSnapMarginTop,
185 CSSPropertyScrollSnapMarginRight, CSSPropertyScrollSnapMarginBottom,
186 CSSPropertyScrollSnapMarginLeft, CSSPropertyScrollSnapMarginBlock,
187 CSSPropertyScrollSnapMarginBlockStart, CSSPropertyScrollSnapMarginBlockEnd,
188 CSSPropertyScrollSnapMarginInline, CSSPropertyScrollSnapMarginInlineStart,
189 CSSPropertyScrollSnapMarginInlineEnd, CSSPropertyScrollSnapStop};
180 190
181 CSSValueID CssIdentifierForFontSizeKeyword(int keyword_size) { 191 CSSValueID CssIdentifierForFontSizeKeyword(int keyword_size) {
182 DCHECK_NE(keyword_size, 0); 192 DCHECK_NE(keyword_size, 0);
183 DCHECK_LE(keyword_size, 8); 193 DCHECK_LE(keyword_size, 8);
184 return static_cast<CSSValueID>(CSSValueXxSmall + keyword_size - 1); 194 return static_cast<CSSValueID>(CSSValueXxSmall + keyword_size - 1);
185 } 195 }
186 196
187 void LogUnimplementedPropertyID(CSSPropertyID property_id) { 197 void LogUnimplementedPropertyID(CSSPropertyID property_id) {
188 DEFINE_STATIC_LOCAL(HashSet<CSSPropertyID>, property_id_set, ()); 198 DEFINE_STATIC_LOCAL(HashSet<CSSPropertyID>, property_id_set, ());
189 if (!property_id_set.insert(property_id).is_new_entry) 199 if (!property_id_set.insert(property_id).is_new_entry)
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
564 "These styles are computed, and therefore the '" + 574 "These styles are computed, and therefore the '" +
565 getPropertyNameString(id) + "' property is read-only."); 575 getPropertyNameString(id) + "' property is read-only.");
566 } 576 }
567 577
568 DEFINE_TRACE(CSSComputedStyleDeclaration) { 578 DEFINE_TRACE(CSSComputedStyleDeclaration) {
569 visitor->Trace(node_); 579 visitor->Trace(node_);
570 CSSStyleDeclaration::Trace(visitor); 580 CSSStyleDeclaration::Trace(visitor);
571 } 581 }
572 582
573 } // namespace blink 583 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698