third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-canvas.html - Issue 2932593002: Attempt 2: Update PaintTiming Web Perf APIs for FP & FCP to report swap time

Unified Diff: third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-canvas.html

Issue 2932593002: Attempt 2: Update PaintTiming Web Perf APIs for FP & FCP to report swap time (Closed)

Patch Set: replace var with let Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-bg-image.html ('K') | « third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-bg-image.html ('k') | third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-image.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-canvas.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-canvas.html b/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-canvas.html

index d07d06ef423e233f9b8dc1575af39b59c95a5f2d..020002d7ce30c90489ff6a94c4dca6fad99bfe0b 100644

--- a/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-canvas.html

+++ b/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-canvas.html

@@ -1,46 +1,31 @@

<!DOCTYPE html>

<head>

-<title>Performance Paint Timing Test</title>

+<title>Performance Paint Timing Test: FCP due to canvas</title>

</head>

<body>

+ <canvas id="canvas" width="200" height="200" ></canvas>

async_test(function (t) {

- var observer = new PerformanceObserver(

- t.step_func(function (entryList) {

- var entries = entryList.getEntries();

- assert_equals(entries.length, 2,

- "There should be two paint timing instances.");

- assert_equals(entries[0].entryType, "paint",

- "Expected entryType to be: paint.");

- assert_equals(entries[0].duration, 0,

- "Expected duration to be: 0.");

+ let c = document.getElementById("canvas");

tdresser 2017/06/12 14:44:45 constq

+ var ctx = c.getContext("2d");

tdresser 2017/06/12 14:44:45 const

+ ctx.beginPath();

+ ctx.moveTo(0,0);

+ ctx.lineTo(300,150);

+ ctx.stroke();

- assert_equals(entries[1].entryType, "paint",

- "Expected entryType to be: paint.");

- assert_equals(entries[1].duration, 0,

- "Expected duration to be: 0.");

- observer.disconnect();

- t.done();

- })

- );

- observer.observe({entryTypes: ["paint"]});

+ testRunner.capturePixelsAsyncThen(t.step_func_done(function() {

+ const bufferedEntries = performance.getEntriesByType('paint');

+ assert_equals(bufferedEntries.length, 2, "There should be two paint timing instances.");

+ assert_equals(bufferedEntries[0].entryType, "paint");

+ assert_equals(bufferedEntries[0].name, "first-paint");

+ assert_equals(bufferedEntries[1].entryType, "paint");

+ assert_equals(bufferedEntries[1].name, "first-contentful-paint");

+ }));

}, "First contentful paint fires due to canvas render.");

</script>

- <script>

- window.onload = function() {

- var c=document.getElementById("canvas");

- var ctx=c.getContext("2d");

- ctx.beginPath();

- ctx.moveTo(0,0);

- ctx.lineTo(300,150);

- ctx.stroke();

- }

- </script>

- <canvas id="canvas" width="200" height="200" ></canvas>

</body>

</html>