third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html - Issue 2932593002: Attempt 2: Update PaintTiming Web Perf APIs for FP & FCP to report swap time

Unified Diff: third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html

Issue 2932593002: Attempt 2: Update PaintTiming Web Perf APIs for FP & FCP to report swap time (Closed)

Patch Set: fix punctuation Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-paint.html ('K') | « third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-paint.html ('k') | third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-paint-only.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html b/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html

index 8bc773295ed82183c22ca54e3b2cdc0e9358e0d2..f75e71a59bfd658e5e9f6039d1f0330e4d3c12b2 100644

--- a/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html

+++ b/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html

@@ -5,39 +5,22 @@

<body>

+ <div id="svg"></div>

async_test(function (t) {

- var observer = new PerformanceObserver(

- t.step_func(function (entryList) {

- var entries = entryList.getEntries();

- assert_equals(entries.length, 2,

- "There should be two paint timing instances.");

- assert_equals(entries[0].entryType, "paint",

- "Expected entryType to be: paint.");

- assert_equals(entries[0].duration, 0,

- "Expected duration to be: 0.");

- assert_equals(entries[1].entryType, "paint",

- "Expected entryType to be: paint.");

- assert_equals(entries[1].duration, 0,

- "Expected duration to be: 0.");

- observer.disconnect();

- t.done();

- })

- );

- observer.observe({entryTypes: ["paint"]});

+ var img = document.createElement("IMG");

+ img.src = "resources/circle.svg";

+ document.getElementById('svg').appendChild(img);

tdresser 2017/06/08 14:34:32 Would this be clearer in html vs js?

panicker 2017/06/08 22:47:04 the reason to do stuff in JS is to control timing

tdresser 2017/06/09 14:26:27 In this example, what would the difference in timi

panicker 2017/06/09 20:29:48 I think in this case it's fine because I moved the

+ testRunner.capturePixelsAsyncThen(t.step_func_done(function() {

+ bufferedEntries = performance.getEntriesByType('paint');

+ assert_equals(bufferedEntries.length, 2, "There should be two paint timing instances.");

+ assert_equals(bufferedEntries[0].entryType, "paint");

+ assert_equals(bufferedEntries[0].name, "first-paint");

+ assert_equals(bufferedEntries[1].entryType, "paint");

+ assert_equals(bufferedEntries[1].name, "first-contentful-paint");

+ }));

}, "First contentful paint fires due to svg.");

</script>

- <script>

- window.onload = function() {

- var img = document.createElement("IMG");

- img.src = "resources/circle.svg";

- document.getElementById('svg').appendChild(img);

- }

- </script>

- <div id="svg"></div>

</body>

</html>